replace standard marker and favorite marker icons

[jancborchardt]

Before & after: More in line with simple ownCloud style. Please review @v1r0x @Henni

[v1r0x]

Looks nice! :+1: from me A little enhancement: Do we want to have the marker shadow?

[jancborchardt]

I removed it because it was also not visible for the favorite markers. But maybe yes, it’s better to have it to visually separate it from the map. Will adjust.

[v1r0x]

Any news, @jancborchardt ?

[Henni]

Why does this PR modify a 3rdParty file (i.e. js/3rdparty/leaflet/leaflet-src.js)?

[jancborchardt]

As soon as I add the shadow back, it won't mess with 3rdparty files anymore I think.

[v1r0x]

@jancborchardt any update on this?

[v1r0x]

@jancborchardt ping?

[Henni]

@v1r0x i believe @jancborchardt is on vacation this week

[v1r0x]

Does he even work? :D

[v1r0x]

@jancborchardt Any news?

[v1r0x]

@jancborchardt Hope you are not mad, but I decided to revert the js changes and adjusted the fav icon and added a new shadow marker. @jancborchardt @Henni What do you think? Ready to merge?

[jancborchardt]

@v1r0x nah, I just need to test. :) The favorite marker looks a tad better too.

The SVG files definitely need to be compressed though – using Scour, with the line from core/img/image-optimization.sh, if you want to play around with that. ;)

[v1r0x]

@jancborchardt I used scout with the settings from the shell script and also moved the files to another folder. Thus all marker icons are in one folder and not in different folders. I'll squash the commits if you (and/or @Henni) are ok with the changes :)

[Henni]

The navigation markers are broken. Otherwise looks good:

[v1r0x]

Unfortunately the routing machine uses the hardcoded (or taken from leaflet.js) path to the old .png file. I tried to copy the current marker as png to the old path, but this distorts the marker icon.

[v1r0x]

Got it!

[jancborchardt]

Ok, let’s get this in – we can always polish more in future pull requests. :)