owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Unify popup data display & style #109

Closed jancborchardt closed 8 years ago

jancborchardt commented 8 years ago

There’s a bunch of different ways we currently display info in the popup. And we should make it so it all has a consistent look.

The favorite popup is the best example at the moment. Nice h2 header with the most important thing in it. Not much other info though – partly by design (like not having the coordinates etc) but partly it would be cool to have details like address and opening hours. capture du 2015-12-31 11-31-51

The opposite here in the POI popup, basically a raw database dump. This is the same store as above, but that’s completely lost in the sea of other info. capture du 2015-12-31 11-32-32 A nice display of this data would be:

Suicycle Store Wohlwillstraße 12, 20359 Hamburg (St. Pauli) +49…clickable phone number for mobile use suicycle-store.com ↗ clickable link, opens externally [Navigate here] as a button

Here for when you click on the map: capture du 2015-12-31 11-31-33 Same exercise:

Porsche Design Poststraße 2–4, 20354 Hamburg (Neustadt) [Navigate here]

Extra boroughs and especially the country can just be left out. We mainly need to cut out useless info and reorder the rest.

And yet another format where the commas were already replaced by line breaks: capture du 2015-12-31 11-30-41

Gruner + Jahr Am Baumwall 11, Hamburg (Mitte) [Navigate here]

v1r0x commented 8 years ago

Absolutely! I don't know how we could unify those informations. I'll look into it soon, hopefully ;)

jancborchardt commented 8 years ago

In the first case (2nd screenshot) it’s the name property, and in the other two examples it’s the first element. So that could always be the h2, and the rest in the following p. That would already be a massive improvement.

v1r0x commented 8 years ago

I'll have a look at it after the weekend, but we should wait with commits, because I changed some stuff in the other PRs, which would only lead to massive merge conflicts.

jancborchardt commented 8 years ago

Yup, sure.

v1r0x commented 8 years ago

Here's a list of different types we have: