search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

add custom favicon #110

Closed jancborchardt closed 8 years ago

jancborchardt commented 8 years ago

But for some reason it is not displayed. Does this have something to do with the ico fallback we have to do in core for IE8,9,10? I did add the favicon.ico though.

Please check @owncloud/designers @MorrisJobke @v1r0x @Henni

MorrisJobke commented 8 years ago

But for some reason it is not displayed. Does this have something to do with the ico fallback we have to do in core for IE8,9,10? I did add the favicon.ico though.

Yep. We now only support ico files.

jancborchardt commented 8 years ago

I did add the ico though, as said. @MorrisJobke does it work for you?

MorrisJobke commented 8 years ago

I did add the ico though, as said. @MorrisJobke does it work for you?

No and yes - you need following fix: https://github.com/owncloud/core/pull/21482

jancborchardt commented 8 years ago

Nice! Can you test with the fix from core and give your +1 on this? Cc @v1r0x

MorrisJobke commented 8 years ago

:+1:

v1r0x commented 8 years ago

Looks good :+1: