owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Switch Contacts backend #135

Open jancborchardt opened 8 years ago

jancborchardt commented 8 years ago

With 9.0 the Contacts/CardDAV backend moved into core. So for the »show Contacts on map« feature to work, we need to switch the endpoint around. @v1r0x

@DeepDiver1975 @Henni what needs to be done?

Also then for the markers we can show the new color+letter placeholders which @skjnldsv updated: https://github.com/owncloud/core/pull/23638

v1r0x commented 8 years ago

Should we drop OC8 support or try to use the new contacts backend and fallback to the old one if the new doesn't exist?

jancborchardt commented 8 years ago

I’d say dropping ownCloud 8.* support is totally fine. The app is in very early stages, so any time spent for backwards compatibility is wasted atm.

skjnldsv commented 8 years ago

Agreed :)

v1r0x commented 8 years ago

Ok, then we (in this case we means @Henni :D) should use the new backend and drop oc8 support. I think (or rather hope) that we only have to fix these lines: https://github.com/owncloud/maps/blob/master/js/script.js#L1100 https://github.com/owncloud/maps/blob/master/js/script.js#L1110 https://github.com/owncloud/maps/blob/master/js/script.js#L1291 https://github.com/owncloud/maps/blob/master/js/script.js#L1589-L1594

e-alfred commented 8 years ago

This would be quite a nice fix, because contacts now do not work on OC 9.0 at all.

v1r0x commented 8 years ago

Absolutely! I think @Henni (new contacts app dev) has a lot of work with the said app, but maybe he knows what to do?