search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Contacts display doesn’t work if one single address is faulty #14

Closed jancborchardt closed 9 years ago

jancborchardt commented 10 years ago

The contacts layer doesn’t work for me because I get an error 500 on one address. Instead of not working at all, that address should simply be skipped. @brantje

brantje commented 10 years ago

What address is it?

jancborchardt commented 10 years ago

It doesn’t even show that error anymore now. Clicking the »Contacts« entry doesn’t do anything, no log entries anywhere.

brantje commented 10 years ago

Above problem is fixed in eb31405746cdb698e7b6b0367a75bc7ceca142c3

jancborchardt commented 10 years ago

Original problem still kinda stands: Uncaught TypeError: Cannot read property 'street' of undefined script.js

jancborchardt commented 10 years ago

Incomplete addresses should be tried, and skipped if not working. Not leading to nothing working. ;)

brantje commented 10 years ago

I tried this weekend, no errors, does this still exist? If so, can you export the contacts you are using? (Anonymize them first please =) )

jancborchardt commented 10 years ago

@brantje are you testing with your complete address book or just with a few test contacts? Can you make the wrong addresses be logged so I can check which causes it?

brantje commented 10 years ago

Yea, will take an look at it.

jancborchardt commented 9 years ago

Fixed thanks to @v1r0x! :)