owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

https://www.openstreetmap.org #45

Closed hitam4450 closed 9 years ago

hitam4450 commented 9 years ago

Suggestion:

How about to incorporate https://www.openstreetmap.org into OwnCloud ???

Regards, hitam4450

DJaeger commented 9 years ago

What kind of incorporation do you mean?

hitam4450 commented 9 years ago

OKI, I just installed the app and checked it out a little bit. So far, so good! However I use MAPS.ME Version 4.4.7, which uses OpenstreetMap as their base of information. I do have a large number of Bookmarks of locations, which I would like to import into the maps app. The file format for export is named .kmz ! I uploaded the file to a folder in the Fies directory, but I could not find any possibility to import these bookmarks. Is or will it be possible to import bookmarks files into maps??

regards, hitam4450

hitam4450 commented 9 years ago

Is it possible to make the left side panel visible / nonvisible with a toggle switch, what i suggested already in other apps, to make a small screen size more efficient ??

regards, hitam

Henni commented 9 years ago

@hitam4450 this is what happens on mobile/small screens: image

hitam4450 commented 9 years ago

The reasoning is to maximize of the viewing area........!

DJaeger commented 9 years ago

You can toggle the left bar with the icon top left with the three horizontal bars as (nearly) all other ownCloud apps too.

Showing kmz and gpx is already proposed in #39, but no "importing". What do the others think, should the app also be able to import and save them to db? It would be similar to what is happening for location tracking.

@hitam4450: Could you please rename the issue to "importing of locations and tracks"?

Henni commented 9 years ago

@DJaeger It would be great to store such data in the database and also edit it within the app. But this is an issue for later.

DJaeger commented 9 years ago

At least after #39.

hitam4450 commented 9 years ago

@DJaeger Sorry, I do not see any icon top left with three horizontal bars.. OC 8.0.5.2!

Henni commented 9 years ago

@hitam4450 it's only displayed on small screens. Try resizing your browser.

DJaeger commented 9 years ago

You can see, how it should look like in @Henni's Screenshot. If it looks other for you please post a screenshot and which browser with which version you are using.

hitam4450 commented 9 years ago

Well I use FF 39.0.3. I switched from full screen mode to a smaller mode and then I could see the 3 bars... still strange and cumbersome.........!

Henni commented 9 years ago

That is the intended behavior. The sidebar should only be hidden if the window is too small and more screen space is needed.

hitam4450 commented 9 years ago

Ic...thanks for the enlightenment! On my 10" netbook screen the sidebar takes a large portion of the screen!

hitam4450 commented 9 years ago

Just uninstalled the app!

DJaeger commented 9 years ago

@hitam4450: You are still unclear! What is strange and cumbersome? Please be more clear so we can help you!

brantje commented 9 years ago

@hitam4450 means that the sidebar doesn't collapse on mobile.

hitam4450 commented 9 years ago

especially on smaller screens, e.g. 10" netbook screen....... or tablets........

hitam4450 commented 9 years ago

sorry, for my confusing comments........ :-)

DJaeger commented 9 years ago

@brantje: If that is what @hitam4450 means that would be a bug and this should not be closed. But as he speaks of a 10" display, this is a display of "middle big" size. I'm not sure where the breakpoints are, but I think they are not recognized as "small" display. So his behaviour would be correct.

Henni commented 9 years ago

The breakpoint is at about 768 pixels I think.

stefan-niedermann commented 9 years ago

cc @owncloud/designers cc @jancborchardt

summary: There is a user with a 10" notebook. in his opinion the sidebar should be collapsible at this size because it takes too much space. this is not only a maps issue. maybe a reconsideration-issue should be opened in core?

DJaeger commented 9 years ago

@Henni: Yes, you are correct. 768px is the max for the toggle.

jancborchardt commented 9 years ago

Yes, I think in the case of Maps (and also probably Calendar) the default should be to hide the sidebar (mobile mode).

Then though we still have to display the search box. Otherwise it will be a 2-step process to search.

jancborchardt commented 9 years ago

Also @hitam4450 maybe take a bit more time to think your comments through, and use less exclamation marks (!). It comes off as rude and unhelpful otherwise. Thanks!

DJaeger commented 9 years ago

The searchbox could be displayed, as on osm.org when expended the menu, inside a bar on the top. Or like GMaps as flying layer.

hitam4450 commented 9 years ago

I certainly agree to the discussion if the left side panel should be collapsible in Core - as a general feature - or by individually each app! Opened the discussion prior in other apps!

regards., hitam4450

jancborchardt commented 9 years ago

@DJaeger yeah, like Gmaps is what I’m thinking. An always visible part of the left sidebar. And the sidebar only expands when you press the menu button.

Henni commented 9 years ago

@jancborchardt can we solve this in core by implementing a javascript function which enables the switch? Or should the maps app simply override the css rule?

jancborchardt commented 9 years ago

@Henni maybe it needs some adjustment from core, yes. Not sure about that though – do you want to look into that?

Essentially then the Maps app should be able to say something like »mobile mode by default« so the sidebar is hidden and only the switch is visible, even for desktops.

Henni commented 9 years ago

@jancborchardt that's what I had in mind. I won't look into this now. Maybe in a few days. Could you create an issue for this? And if you like you can assign me ;)

DJaeger commented 9 years ago

Please use this issue for maintaining the change in this app as this is the purpose of this issue. It simply needs to be renamed to be more clear.

jancborchardt commented 9 years ago

Nah, this issue started out as something completely different. I opened a new one in core: https://github.com/owncloud/core/issues/18213