Closed Henni closed 9 years ago
Best for @DJaeger and @brantje to review :)
@Henni can you rebase this?
@DJaeger @brantje @v1r0x @vgezer @povoq can you review? :)
Where do you got the information from, that $this->params()
is depricated?
As of the docu is to be used: http://api.owncloud.org/classes/OCP.AppFramework.ApiController.html#params
How should the method calls otherwise determine in which order the params have to be applied?
The removal of TemplateResponse and addtion of LocationManager is ok.
@DJaeger https://github.com/owncloud/core/blob/master/lib/public/appframework/controller.php#L157 I implemented it like this in the tasks app as well.
How should the method calls otherwise determine in which order the params have to be applied?
That's some magic we do with reflection in core. Let me point you to the source code in core, always good to understand how and why things work like they do :smile:
In https://github.com/owncloud/core/blob/c700f42b68f430e9c89ce97b92ea91323c9f6ed5/lib/private/appframework/http/dispatcher.php we do read the parameters there and do call the function with the right parameters then :)
I removed all the insecure defaults and added simple PHPDocs.
Now looks great. :+1: And thanks for the clarification and invitation, @LukasReschke. :-)
YOLO ;-)
This pull-request removes the deprecated function
$this->params()
from the locationcontroller and cleans up few other things.