search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

use url of contacts app for contact pictures #58

Closed v1r0x closed 9 years ago

v1r0x commented 9 years ago

(temporary?) fix for #57

Henni commented 9 years ago

This makes the maps app depend on the contacts app. This is probably not what we want.

v1r0x commented 9 years ago

This is not a new dependency

jancborchardt commented 9 years ago

In any case it should be totally optional. If the Contacts app is not installed, simply do not show the entry in the sidebar and deactivate the functionality.

This is something for a separate PR though it seems?

Henni commented 9 years ago

Yeah right. The difference between Maps & Contacts and Tasks & Calendar is that in this case the dependency isn't mandatory.

jancborchardt commented 9 years ago

Wow … seeing your contacts on the map with images is just pretty awesome! :) Works quite well! :+1:

Regarding the dependency, I opened https://github.com/owncloud/maps/issues/59

jancborchardt commented 9 years ago

@Henni @brantje what do you think?

Henni commented 9 years ago

Looks great! I had the issue that the sprite had blue borders at the right and bottom. But that's probably because my default browser zoom level is 125% and thus it's a browser issue. So :+1: from me

jancborchardt commented 9 years ago

Great stuff @v1r0x, you're awesome! :)

Are you on IRC in our #owncloud-dev channel yet? (Freenode)

v1r0x commented 9 years ago

Thanks :) Now I am