search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

check for contacts dep #60

Closed v1r0x closed 9 years ago

v1r0x commented 9 years ago

see #59

jancborchardt commented 9 years ago

Other than the inline comment it looks ok. Please also review @DJaeger @brantje @Henni :)

v1r0x commented 9 years ago

Don't know how this happened :see_no_evil: Thanks! Should be ok now :)

jancborchardt commented 9 years ago

Cool! Now it would be good if you can squash the 3 commits into one so we keep a clean history. :)

v1r0x commented 9 years ago

Is there an easy way or should I delete all 3 commits and commit a new one with all changes?

Henni commented 9 years ago

@v1r0x Search for 'rebase -i' or 'interactive rebase' in Google.

v1r0x commented 9 years ago

I hope this was right...

Please review @jancborchardt @DJaeger @brantje @Henni

DJaeger commented 9 years ago

Looks good :+1: