Closed jancborchardt closed 8 years ago
Yo folks, simple review. :)
is .leaflet-popup-content-wrapper
used anywhere in the code? Couldn't find it. Maybe we can delete it instead ;)
Yeah, it’s used by the leaflet library. The popup is used for showing details of POIs and contacts. :)
Ah ok, the name is generated and not hardcoded.
in the leaflet css file there is already a definition for this:
https://github.com/owncloud/maps/blob/master/css/leaflet/leaflet.css#l390-l394
should we adjust it there or in the style.css
?
But looks good, :+1:
looks good :+1:
@v1r0x We shouldn't change any of the leaflet files so that we can just replace them if we want to update to a newer version.
@Henni good point :+1:
Please review @v1r0x @Henni @brantje @DJaeger