search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

adjust popup radius to standard ownCloud 3px #71

Closed jancborchardt closed 8 years ago

jancborchardt commented 8 years ago

Please review @v1r0x @Henni @brantje @DJaeger

jancborchardt commented 8 years ago

Yo folks, simple review. :)

v1r0x commented 8 years ago

is .leaflet-popup-content-wrapper used anywhere in the code? Couldn't find it. Maybe we can delete it instead ;)

jancborchardt commented 8 years ago

Yeah, it’s used by the leaflet library. The popup is used for showing details of POIs and contacts. :)

v1r0x commented 8 years ago

Ah ok, the name is generated and not hardcoded. in the leaflet css file there is already a definition for this: https://github.com/owncloud/maps/blob/master/css/leaflet/leaflet.css#l390-l394 should we adjust it there or in the style.css?

But looks good, :+1:

Henni commented 8 years ago

looks good :+1:

@v1r0x We shouldn't change any of the leaflet files so that we can just replace them if we want to update to a newer version.

v1r0x commented 8 years ago

@Henni good point :+1: