search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Make app compliant #75

Closed Henni closed 8 years ago

Henni commented 8 years ago

ownCloud offers an app-checker by executing php occ app:check-code maps.

Currently this leads to the following errors. We should fix them as far as possible:

Analysing /home/hendrik/Coding/owncloud/apps/maps/appinfo/app.php
 4 errors
    line   15: OCP\App::addNavigationEntry - Method of deprecated class must not be called
    line   24: OCP\Util::linkToRoute - Method of deprecated class must not be called
    line   28: OCP\Util::imagePath - Method of deprecated class must not be called
    line   32: OC_L10N - Static method of private class must not be called
Analysing /home/hendrik/Coding/owncloud/apps/maps/controller/pagecontroller.php
 3 errors
    line  122: == - is discouraged
    line  226: == - is discouraged
    line  229: != - is discouraged
Analysing /home/hendrik/Coding/owncloud/apps/maps/controller/locationcontroller.php
 3 errors
    line  120: != - is discouraged
    line  121: != - is discouraged
    line  139: == - is discouraged
App is not compliant
v1r0x commented 8 years ago

nice tool! Will create a PR later the day or tomorrow.

v1r0x commented 8 years ago

please review #76

@Henni

cc @jancborchardt @brantje @DJaeger