search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

made app compliant #76

Closed v1r0x closed 8 years ago

v1r0x commented 8 years ago

fixes #75

v1r0x commented 8 years ago

@Henni @brantje @DJaeger @jancborchardt can we merge this?

Henni commented 8 years ago

I'll take a look. It isn't completely trivial to review this, as these changes could break features in unexpected ways.

brantje commented 8 years ago

Code looks good :+1:

Henni commented 8 years ago

Looks good besides my comment above. :+1:

v1r0x commented 8 years ago

Should we merge this and create a new PR or add this to this PR?

Henni commented 8 years ago

If you are able to fix it now, do it in this PR. Otherwise we'll create another PR.

jancborchardt commented 8 years ago

@v1r0x can you fix the problem noted by @Henni and then rebase? Cause this needs a rebase anyway before we can merge. :)

v1r0x commented 8 years ago

Looks like I messed up the rebase...Any idea how to revert it?

v1r0x commented 8 years ago

Thanks to @PVince81 "I" fixed it ;)

Please review

jancborchardt commented 8 years ago

@Henni everything addressed you had in mind? :)

jancborchardt commented 8 years ago

Btw @v1r0x you are in the ownCloud organization, so it would be much easier if you work on branches in this repo instead of having a personal fork. :) That way all other ownCloud org folks (such as @Henni and me) can collaborate.

Henni commented 8 years ago

what @jancborchardt said...

Otherwise this PR looks good :+1:

v1r0x commented 8 years ago

Will do it next time :) Ok, I'll merge it then?

Henni commented 8 years ago

Feel free to do so :)