Closed v1r0x closed 8 years ago
@Henni @brantje @DJaeger @jancborchardt can we merge this?
I'll take a look. It isn't completely trivial to review this, as these changes could break features in unexpected ways.
Code looks good :+1:
Looks good besides my comment above. :+1:
Should we merge this and create a new PR or add this to this PR?
If you are able to fix it now, do it in this PR. Otherwise we'll create another PR.
@v1r0x can you fix the problem noted by @Henni and then rebase? Cause this needs a rebase anyway before we can merge. :)
Looks like I messed up the rebase...Any idea how to revert it?
Thanks to @PVince81 "I" fixed it ;)
Please review
@Henni everything addressed you had in mind? :)
Btw @v1r0x you are in the ownCloud organization, so it would be much easier if you work on branches in this repo instead of having a personal fork. :) That way all other ownCloud org folks (such as @Henni and me) can collaborate.
what @jancborchardt said...
Otherwise this PR looks good :+1:
Will do it next time :) Ok, I'll merge it then?
Feel free to do so :)
fixes #75