search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Add basic favorite functionality #79

Closed v1r0x closed 8 years ago

v1r0x commented 8 years ago

moved branch to the original repo, related to #9

Henni commented 8 years ago

I fixed some issues with your code:

  1. we need to use setters. Otherwise the mapper doesn't persist the changes in the database
  2. I fixed inconsistent naming of $lon/$lng
  3. userId has to be named user_id in the table (see Database Entities)
v1r0x commented 8 years ago

I fixed some issues with your code:

Thanks!

  1. userId has to be named user_id in the table (see Database Entities)

I had it like this in the first place, but everywhere I saw userId instead of user_id so I changed it, but good to know :)

v1r0x commented 8 years ago

Can we merge this?

Henni commented 8 years ago

@v1r0x Please remove the debug outputs first and squash the commits.

v1r0x commented 8 years ago

@Henni done

Henni commented 8 years ago

Looks good to me :+1:

Can we get another review, please? @brantje @DJaeger

short remark: this doesn't completely fix #9, but is a first step towards it (see https://github.com/owncloud/maps/issues/9#issuecomment-157835452). This PR implements the option to add favorites. Another PR will actually display them. Are you already working on this @v1r0x ?

v1r0x commented 8 years ago

I edited my comment in OP.

@Henni Yes, already started, but I'd like to discuss/ask some things in the issue to decide how to implement it

v1r0x commented 8 years ago

Can anyone else please review this, so we can move to the next step of #9 ? :)

cc @DJaeger @brantje @jancborchardt

jancborchardt commented 8 years ago

We can go for single thumbs-up reviews for now. :) We’re not enough people yet for consistent 2-thumbs-up reviews, and we don’t have a release yet.