Closed v1r0x closed 8 years ago
I fixed some issues with your code:
I fixed some issues with your code:
Thanks!
- userId has to be named user_id in the table (see Database Entities)
I had it like this in the first place, but everywhere I saw userId
instead of user_id
so I changed it, but good to know :)
Can we merge this?
@v1r0x Please remove the debug outputs first and squash the commits.
@Henni done
Looks good to me :+1:
Can we get another review, please? @brantje @DJaeger
short remark: this doesn't completely fix #9, but is a first step towards it (see https://github.com/owncloud/maps/issues/9#issuecomment-157835452). This PR implements the option to add favorites. Another PR will actually display them. Are you already working on this @v1r0x ?
I edited my comment in OP.
@Henni Yes, already started, but I'd like to discuss/ask some things in the issue to decide how to implement it
Can anyone else please review this, so we can move to the next step of #9 ? :)
cc @DJaeger @brantje @jancborchardt
We can go for single thumbs-up reviews for now. :) We’re not enough people yet for consistent 2-thumbs-up reviews, and we don’t have a release yet.
moved branch to the original repo, related to #9