owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

Autocomplete addresses from Contacts #8

Open jancborchardt opened 10 years ago

jancborchardt commented 10 years ago

When typing »Sander« into the search field (and assuming I have your address in ownCloud Contacts) I should get the suggestion »Sander, Somestreet, Somecity, Netherlands«.

This would be a great example of inter-app connection in ownCloud. If you want to see how it’s done, check out the mail app code: https://github.com/owncloud/mail (we do that for the »to« and »cc« fields)

scolebrook commented 10 years ago

It would be awesome if the same could be done between this app and the ldap backend (it'd obviously need some reworking to make that data available). Are we setting milestones for OC 10 yet? :smile:

jancborchardt commented 10 years ago

Well, this here is about the Contacts app for now, not about the user management. Cause there we don’t even have addresses.

v1r0x commented 9 years ago

I wrote a piece of code, which filters contact names and their addresses based on the search term. But I won't create a PR, since this is currently not good code and there are still peding PRs

jancborchardt commented 9 years ago

@v1r0x yeah, I’ll hope to get to it these days. :) The ownCloud conf was very busy. Hope you can make it next year, probably end of August again! https://owncloud.org/conf

v1r0x commented 9 years ago

@jancborchardt hopefully! There should be no thesis next year ;) maybe you are at the 32c3 in december, too? and don't hurry, I'm on holiday the next weeks. But I didn't want to spam more PRs with different master ;)

jancborchardt commented 9 years ago

@v1r0x if you just always branch PRs off master then it should be fine. :) Not sure yet if I’ll come to C3 this year, I was at CCCamp though. Where are you based? Let me know if you happen to be in Munich any time. :)

v1r0x commented 9 years ago

@jancborchardt I know, but I continued master on my productive setup (I know this is not clever :D) and thus I have all my PRs already included. Will separate them after my holiday. I'm close to Stuttgart, but I'm at Munich tonight for about 2 hours ;)

jancborchardt commented 9 years ago

@v1r0x hehe, yeah it’s indeed not clever. ;) Master should never be worked on, only in branches which can then be opened as pull requests.

jancborchardt commented 9 years ago

And yeah, see you later! :)