search

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud
GNU Affero General Public License v3.0
42 stars 20 forks source link

added possibility to load gpx track files #81

Open v1r0x opened 8 years ago

v1r0x commented 8 years ago

See #65 for more info fixes #39

cc @jancborchardt @Henni @DJaeger @brantje

jancborchardt commented 8 years ago

cc @Frank1604 as well of the GPX viewer app (source) just as on the other pull request.

v1r0x commented 8 years ago

Thanks @jancborchardt totally forgot to add him

jancborchardt commented 8 years ago

Also here, cc'ing the relevant folks of the other GPX apps:

@Frank1604 @eneiluj let’s work together on one nice Maps app with proper functionality. :)

Henni commented 8 years ago

I fixed a syntax error (a657443) Seems to work with the example gpx file from https://wiki.openstreetmap.org/wiki/GPX Great work @v1r0x!

Also there is still some stuff missing:

v1r0x commented 8 years ago

@Henni thanks for your comments and your fix! After we finished 0.1 milestone I'll get back to this one. Maybe @Frank1604 or @eneiluj can help with that one. :)

show more information like direction, height map

jancborchardt commented 8 years ago

So should this be merged for now and improvements made in further PRs?

Henni commented 8 years ago

@jancborchardt currently clicking "MyTracks" doesn't do anything and clicking "upload" shows an alert. These two points should be solved before we merge this in by either removing these options for now or implementing their functionality.

jancborchardt commented 8 years ago

In any case, is this smth for 0.1 or rather 0.2?

v1r0x commented 8 years ago

IMO this is 0.2, nothing what a basic maps app should have, but of course a nice feature. I would first finish 0.1 and then try to finish and merge this one. We should focus on close pending PRs and and open 0.1 tickets.

jancborchardt commented 8 years ago

Then we should hide all tracks functionality for 0.1, right? Also the device tracking stuff?

v1r0x commented 8 years ago

I don't know how and if the device tracking works. If yes, I think we don't have to hide it. All the other track stuff shouldn't be visible on master right now.

jancborchardt commented 8 years ago

Yeah, I'm kinda thinking about hiding all non-essential Maps stuff for 0.1 and totally focus on the basics. Then after we release 0.1, we can work on polishing all the flows. Cause while these things might work when you fiddle around with them, it's not easily apparent. What do you think @v1r0x @Henni and others?

Henni commented 8 years ago

@jancborchardt Probably a good idea. Let's hide the devices for now

v1r0x commented 8 years ago

Sounds good.