Closed v1r0x closed 8 years ago
Can we merge? Or should I replace anonymous with NULL
and set $name
to NULL
if it is empty?
What do you think @jancborchardt @Henni @DJaeger @brantje ?
I would use NULL. How would you handle the favorite name, if the user really names it Anonymous?
I would use NULL. How would you handle the favorite name, if the user really names it Anonymous?
You're right. I already wanted to edit this, but I moved to a new flat and have no internet there :( ;)
:+1:
@jancborchardt: Sounds good
I replaced Anonymous
with NULL
and the dialog prompt with a inline input field. What do you guys think?
Why do you store NULL
as the string empty
in the table?
I think you refer to an old commit. Should be replaced by $name
@v1r0x: yes, I actually still had some old entries in the database.
Empty names seem to be stored as ''
(empty string) which is maybe even better than NULL
.
''
should be equal to null
:)
@v1r0x it’s better! :) However some more enhancements, which maybe should come in a separate PR:
So should we merge this one and cover your enhancements in the other issues or a separate PR?
@jancborchardt I added two of your enhancements. Replacing "add to favorites" with a star in the upper left is a bit more complicated, because I extract the title of the popup's html code, since I found no other way to access the popup's content. Therefore adding the star would use the star's html code as title. I would cover this in another PR.
I would squash the commits and merge. Is this ok? @jancborchardt @Henni @DJaeger @brantje
Cool with me. :) Just ideally open a follow-up issue then.
:+1:
After clicking on "add to favorites" a prompt pops up so that the user can enter a name for this favorite marker. In a later PR this could be extended to only prompt if it is not a POI or contact (for POI or contact the app should use the POI's/contact's name as name).
Another part of #9 What do you think? @jancborchardt @Henni @DJaeger