Favorites

[jancborchardt]

It should be possible to set points as favorites. They could be shown with star markers on the map, and this layer could be possible to disable in the sidebar.

Similarly, Contacts addresses could be shown as favorites by default (or at least the addresses of the contacts you set as favorite in the Contacts app).

cc @brantje

[brantje]

• [x] Possibility to drop an marker
• [ ] Handle click event
• [ ] Add backend logic

[ant0nioli]

I can't add favorites. When I click the ling on the POI nothing happens. Tks.

[jancborchardt]

cc @v1r0x for info. :)

[v1r0x]

I implemented it right now. But I don't know how to get/set the name of a favorite? WIth my JS "skills" I couldn't get the information of the added POI. Any ideas how to do this?

@jancborchardt cc @DJaeger @Henni

[jancborchardt]

cc @MorrisJobke @PVince81 @Henni for JS knowledge. :)

[ant0nioli]

Hi @v1r0x and @jancborchardt. In these days I'm pretty busy, but as soon as I can I will take a look to that. Maybe joining our skills we can get through that :)

[jancborchardt]

@acaparrelli would be really cool to have you on board for the Maps app when you have more free time! :)

[ant0nioli]

I would love to do that @jancborchardt ! :) On 16/11/2015 11:27, Jan-Christoph Borchardt wrote:

@acaparrelli https://github.com/acaparrelli would be really cool to have you on board for the Maps app when you have more free time! :)

— Reply to this email directly or view it on GitHub https://github.com/owncloud/maps/issues/9#issuecomment-156982000.

AC.

[v1r0x]

The most important question is what we want to store? Currently a user defined name, latitude, longitude, user_id and a timestamp is stored.

[jancborchardt]

Additionally what Maps.me seems to store is a group, color of marker (depends on group), and a Notes field.

[ant0nioli]

As @jancborchardt I think a Tag (or we could call it Group or Category) and a Color should be assigned to each POI. This would be useful to group POIs ("restaurants", "best stores", "tapas bars", etc) and even to give the ability of embedding POIs Tag's maps in public HTML websites. I mean, embed a map with "restaurants" only or a map with "restaurants" + "tapas bars" + ...

Note field would be great too.

On 17/11/2015 12:50, v1r0x wrote:

The most important question is what we want to store? Currently a user defined name, latitude, longitude, user_id and a timestamp is stored.

— Reply to this email directly or view it on GitHub https://github.com/owncloud/maps/issues/9#issuecomment-157347504.

AC.

[v1r0x]

So if I want to add @jancborchardt address as favorite, only the lat/lon is stored without the street, city, etc.?

[ant0nioli]

I think that storing city, street, number etc it would be more precise and future proof

[jancborchardt]

We need to use the lat/long because you can also add favorites in random places where there’s no address or when the thing you’re trying to favorite doesn’t exist yet on OpenStreetMap. An address can be supplementary, but can never be the identifying factor.

[v1r0x]

Should we only store lat/lon for now?

[jancborchardt]

Start small, yep. Lat/lon is the absolute minimum. Name is next – can be prefilled by the establishment you favorite, if it is any, and can be custom filled in the future. Everything else is additional.

[v1r0x]

Ok, I will create a PR with my code later

[v1r0x]

Create the PR #78 but the data in the DB is always NULL. Any idea what is wrong? @jancborchardt @Henni @DJaeger

[v1r0x]

Should we add the Favorite-Layer to the sidebar and showing them on the maps in the current PR #79 or in a new one?

[jancborchardt]

Separate one is better – always small steps. :)

[v1r0x]

Now that we have a very basic favorite functionality I'd like to collect the desired contents of this issue.

• [ ] Set favorite contacts as favorite marker by default
• [x] Add a sidebar entry (toggle) for favorites #82
• [x] display favorites #82
• [x] Set user-defined name #85
• [ ] Remove favorite?
• [ ] Add feedback for currently added favorite (see discussion in #85)
• [ ] Beautify fav dialog (see #90/#91)

Did I miss something?

[jancborchardt]

Yep, that's a good next step! I like the direct integration of favorite Contacts, good thinking.

[v1r0x]

It was your idea in the OP ;)

[jancborchardt]

@v1r0x lol :D I guess good job @jancborchardt then …

[Henni]

advanced todos:

• [ ] prevent duplicate favorites

maybe these should be their own issues

[v1r0x]

I think all icons should be prettier, not only the fav marker, so I would definitely move this to it's own issue

[v1r0x]

I tried to implement the contact favorite thing, but I couldn't find any API or entry in the VCARD which allows me to get the information if a contact is starred or not. Did I miss something or is it not possible?

[jancborchardt]

Is that possible with the new CardDAV API? @Henni @DeepDiver1975

[jancborchardt]

It’s all in the individual issues now so I’m closing this. Also see »Ability to remove favorites« https://github.com/owncloud/maps/issues/95