Add star icon - Githubissues

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud

GNU Affero General Public License v3.0

42 stars 20 forks source link

Add star icon #91

Closed v1r0x closed 8 years ago

v1r0x commented 8 years ago

As discussed in #85 and mentioned in #90 this adds a star icon to the popup dialog. This is WIP and a few things are not yet implemented, but will be:

[x] Move star icon to the left
[x] ~~The icon looks a bit stretched, doesn't it?~~ Not stretched, but cut off. Any ideas? @jancborchardt
[x] Remove "Add to favorites"
[ ] Toggle the star icon if the user added/removed a marker

Additions and feedback are welcome! :)

cc @jancborchardt @Henni @DJaeger @brantje

fixes #90

jancborchardt commented 8 years ago

Yeah, already cool! The main problem is the missing direct feedback of the marker being added/removed when the favorite is set/unset: https://github.com/owncloud/maps/issues/88 ;)