'Remove favorite' functionality

owncloud-archive / maps

:globe_with_meridians: Maps app for ownCloud

GNU Affero General Public License v3.0

42 stars 20 forks source link

'Remove favorite' functionality #98

Closed v1r0x closed 8 years ago

v1r0x commented 8 years ago

fixes #95

v1r0x commented 8 years ago

@jancborchardt @Henni @DJaeger Could you please review this? :)

jancborchardt commented 8 years ago

Nice! Just a few details:

[ ] I would say the popover should stay open when unfavoriting, just the star should then be grey. Since you might still want to view it, or pressed it by accident. It’s a bit jarring to just directly close it. Not entirely sure about it, but seemed a bit odd.
[ ] The marker should then also transform into a normal marker
[x] All the favorite markers flash once, I guess because they are all reloaded? If possible, only the relevant marker should be removed.

v1r0x commented 8 years ago

Replacing the star-icon is rather easy, but replace the marker icon seems to be impossible. Maybe creating a new marker and force to open the popup might be possible as workaround, but I don't know. If this is not possible I would use the current solution and delete (and thereby close) the marker.

v1r0x commented 8 years ago

We should fix this in #88 since there it should be the same. Are you ok with this? And can we merge this for now then?

jancborchardt commented 8 years ago

Yup! :)