owncloud-archive / shorty

15 stars 12 forks source link

js file not found: script:js/chosen/chosen.jquery.min #104

Closed LEDfan closed 9 years ago

LEDfan commented 9 years ago

Hi

I get an error when I go to the admin panel: 'js file not found: script:js/chosen/chosen.jquery.min'.

Note that I'm running oC8.0

arkascha commented 9 years ago

Which version / source of Shorty do you use?

LEDfan commented 9 years ago

Both master branch and appstore. I'll provide a patch tomorrow.

arkascha commented 9 years ago

Could it be that this is not an issue with one of the Shorty apps, but a general problem with the OC core? I fail to get OC-8.0.0RC2 working and I get exactly the same error message. Indeed it appears that all 3rdparty js and css files are simply missing in the release candidate. But there seem to be more issues.

LukasReschke commented 9 years ago

You need to move the JS and CSS files into your own app. We're not shipping it anymore as they were never considered part of any public API.

Ref https://github.com/owncloud/core/pull/11983

LukasReschke commented 9 years ago

Generally speaking: You can only really rely on jQuery being available as 3rdparty file. All other things may disappear at any time if not explicit in a public API.

LEDfan commented 9 years ago

Jep, providing the chosen.min.js, solves the error. But when I want to open the short app it redirects to the files app. '#

arkascha commented 9 years ago

@LukasReschke Thanks for pointing that out. I will take care of that. Once more an issue that needlessly inflates app code. If they were never "officially" part of owncloud, then how can it be they got shipped? @LEDfan Yep, experiencing that too, no idea what's up so far. This is one of the things I meant with "But there seem to be more issues."...

LEDfan commented 9 years ago

I managed to fix the app :) I'll push my changes later today.

arkascha commented 9 years ago

I made some house keeping today: