phil-davis commented 5 years ago

After waiting for the AJAX with the users list to come in UsersPage waitTillPageIsLoaded() we know that we have some real users (at least "admin") listed on the page. But when we continue at that time to "get on with the test steps" then we often have trouble with the notification popup not happening (at least not being found).

Adding waitForOutstandingAjaxCalls() is a reasonable thing, but actually that returns "straight away" because the AJAX calls have finished. So that is not the complete solution.

For now, we need to get this reliable, so we also add sleep(1) to the end of UsersPage waitTillPageIsLoaded(). I have run the webUIManageQuota suite over-and-over and it passes 100% with the sleep(1). Without the sleep, then this step fails a lot to find the notification:

Then a notification should be displayed on the webUI with the text 'Invalid quota value "<wished_quota>"'

So the workaround for now is to put the sleep in the code.

Issue #167 has been raised to look into this further.

codecov[bot] commented 5 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     78.71%   78.71%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           916      916           
=========================================
  Hits            721      721           
  Misses          195      195

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2bba50...cbe9916. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     78.71%   78.71%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           916      916           
=========================================
  Hits            721      721           
  Misses          195      195

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2bba50...cbe9916. Read the comment docs.

owncloud-archive / user_management

Wait longer in users page wait till page is loaded #166

Codecov Report

Codecov Report