owncloud-archive / user_management

GNU Affero General Public License v3.0

2 stars 3 forks source link

Use html body for message sent via email for password change #181

Closed sharidas closed 5 years ago

sharidas commented 5 years ago

Use html body for message sent via email for password change.

Signed-off-by: Sujith H sharidasan@owncloud.com

sharidas commented 5 years ago

Description

The message sent via email for password success to the user should be sent in html instead of plain text. This change addresses the issue.

Issue

Fixes https://github.com/owncloud/core/issues/35255

How is it tested

Create an user with email id
Access the email to set the password for the user
Once the password is successful verify the email to see the password change. Here are the screenshots

HTML

Screenshot_2019-05-17 MailHog

Plain Text

Screenshot_2019-05-17 MailHog(1)

codecov[bot] commented 5 years ago

Codecov Report

Merging #181 into master will not change coverage. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage     78.73%   78.73%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           917      917           
=========================================
  Hits            722      722           
  Misses          195      195

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/UsersController.php	`85.97% <100%> (ø)`	`134 <0> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d52e1fc...206c7a4. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #181 into master will increase coverage by 0.06%. The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #181      +/-   ##
===========================================
+ Coverage     78.73%   78.8%   +0.06%     
  Complexity      214     214              
===========================================
  Files            26      26              
  Lines           917     920       +3     
===========================================
+ Hits            722     725       +3     
  Misses          195     195

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/UsersController.php	`86.05% <100%> (+0.08%)`	`134 <0> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d52e1fc...369947c. Read the comment docs.

micbar commented 5 years ago

LGTM now. Lets wait for drone.

sharidas commented 5 years ago

Backport PR https://github.com/owncloud/core/pull/35260