search

owncloud-archive / user_management

GNU Affero General Public License v3.0
2 stars 3 forks source link

Remove stable10 test jobs #197

Closed phil-davis closed 5 years ago

phil-davis commented 5 years ago

Issue https://github.com/owncloud/core/issues/35777

The old core stable10 is now master

There is likely to be trouble here, because there is no longer any core branch that has user_management removed.

phil-davis commented 5 years ago

https://github.com/owncloud/core/pull/28169 that implements ISubAdminManager is not in "the new master", so that prevents this separate user_management app from working.

patrickjahns commented 5 years ago

@phil-davis

Please check EXCLUDE https://github.com/owncloud-ci/core

It was used in files_encryption https://github.com/owncloud/encryption/blob/master/.drone.yml#L13

phil-davis commented 5 years ago

@phil-davis

Please check EXCLUDE https://github.com/owncloud-ci/core

It was used in files_encryption https://github.com/owncloud/encryption/blob/master/.drone.yml#L13

thanks for the hint - I knew there was magic available somewhere ;)

phil-davis commented 5 years ago

This is still a problem:

https://drone.owncloud.com/owncloud/user_management/956/35

There were 13 warnings:

1) OCA\UserManagement\Test\Unit\ChangePasswordControllerTest::testPasswordChange with data set "success" ('success', true, false)
Cannot stub or mock class or interface "OCP\ISubAdminManager" which does not exist

2) OCA\UserManagement\Test\Unit\ChangePasswordControllerTest::testPasswordChange with data set "sub admin" ('success', false, true)
Cannot stub or mock class or interface "OCP\ISubAdminManager" which does not exist

3) OCA\UserManagement\Test\Unit\ChangePasswordControllerTest::testPasswordChange with data set "no admin, no subadmin" ('error', false, false)
Cannot stub or mock class or interface "OCP\ISubAdminManager" which does not exist

4) OCA\UserManagement\Test\Unit\ChangePasswordControllerTest::testPasswordChange with data set "password change fails" ('error', true, false, false)
Cannot stub or mock class or interface "OCP\ISubAdminManager" which does not exist

5) OCA\UserManagement\Test\Unit\PageControllerTest::testIndex
Cannot stub or mock class or interface "OCP\ISubAdminManager" which does not exist

6) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testBeforeControllerAsUserWithExemption
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

7) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testBeforeControllerAsUserWithoutExemption
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testBeforeControllerAsSubAdminWithoutExemption
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testBeforeControllerAsSubAdminWithExemption
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testAfterNotAdminException
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) OCA\UserManagement\Test\Unit\SubadminMiddlewareTest::testAfterRegularException
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) OCA\UserManagement\Test\Unit\UsersControllerTest::testSetSelfEmailAddress with data set #0 ('foo', 'foo', 'foo@localhost')
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) OCA\UserManagement\Test\Unit\UsersControllerTest::testSetSelfEmailAddress with data set #1 ('bar', 'foo', 'foo@localhoster')
Trying to configure method "getSubAdmin" which cannot be configured because it does not exist, has not been specified, is final, or is static

WARNINGS!
Tests: 98, Assertions: 276, Warnings: 13.

@micbar @DeepDiver1975 @patrickjahns were are we going with this separate user_management app?

patrickjahns commented 5 years ago

@phil-davis This is not likely in scope of a 10.3

phil-davis commented 5 years ago

@phil-davis This is not likely in scope of a 10.3

That's fine. For now, we could

phil-davis commented 5 years ago

@patrickjahns @DeepDiver1975 maybe override CI and merge this small drone PR so that the obvious changes are there?

Then we can later decide what is the plan for this app repo.

phil-davis commented 5 years ago

@patrickjahns @DeepDiver1975 can someone force merge this, just to get it out of the way and have the obvious changes related to the core stable10 stuff merged?