search

owncloud-docker / helm-charts

ownCloud Server Helm charts
https://owncloud-docker.github.io/helm-charts/
Apache License 2.0
4 stars 10 forks source link

Ingress Class in Values.yaml wrong #79

Closed PeeK1e closed 6 months ago

PeeK1e commented 7 months ago

Theres is an discrepancy in the ingress template and the values yaml for the ingress class name

templates/ingress.yaml:

  {{- with .Values.ingress.className }}
  ingressClassName: {{ . }}
  {{- end }}

values.yaml:

ingress:
  # -- Enables the Ingress.
  enabled: false
  # -- Ingress class to use.
  # Uses the default ingress class if not set.
  ingressClassName: ""

{{- with .Values.ingress.className }} should be {{- with .Values.ingress.ingressClassName }}

It's up to you to fix the naming but it should be correct :P (The readme is also incorrect)

xoxys commented 7 months ago

Thanks, good catch. Fixed it the other way around and renamed the values ref to ingress.className.