search

owncloud-docker / server

Docker image for ownCloud community edition
MIT License
442 stars 127 forks source link

build: add 10.13.4 #453

Closed jnweiger closed 11 months ago

jnweiger commented 11 months ago

Implemented in https://github.com/owncloud-docker/base/pull/321

TheRealBro commented 11 months ago

Merged PR to base container, although I have to say the implementation of this feature is quite bad. Asking a config value (which might be compromised by an attacker) to show a security warning or not at update is maybe not the best idea. Plus it adds way more overhead in deployments. I would ask to revert this and start from scratch rethinking the design of this "Warning", but that's above my paygrade. For here, we at least documented it and can disable the warning in automated deployments.

jnweiger commented 11 months ago

Merged PR to base container, although I have to say the implementation of this feature is quite bad. Asking a config value (which might be compromised by an attacker) to show a security warning or not at update is maybe not the best idea. Plus it adds way more overhead in deployments. I would ask to revert this and start from scratch rethinking the design of this "Warning", but that's above my paygrade. For here, we at least documented it and can disable the warning in automated deployments.

Good thinking! I've thought about that briefly, but quickly (maybe too quickly) dismissed concerns: an attacker who can edit config.php has probably already enough edit power to remove anything from the admin UI that he wants to remove.