phpstan 0.12 in all repos

[phil-davis]

phpstan is at various versions in different core and app repos.

• update phpstan to 0.12
• in those repos where it is already passing and running in CI, adjust code and/or settings to keep it passing
• review Makefile to see that it has the "standard" code related to phpstan, the vendor-bin dir and clean of that (e.g. I noticed that some Makefile do not clean vendor-bin when make clean is done)

The new phpstan gives this tip: https://drone.owncloud.com/owncloud/files_lifecycle/1104/2/5

One or more properties in your code do not have a phpDoc with a type
but it could be inferred from the constructor to find more bugs.
Use inferPrivatePropertyTypeFromConstructor: true in your ./phpstan.neon to try it out!

• try adding inferPrivatePropertyTypeFromConstructor setting also

[phil-davis]

This is the list of apps to check: (some do not have any phpstan set up, so ignore those and delete from the list)

• [x] activity (no php stan)
• [x] admin_audit https://github.com/owncloud/admin_audit/pull/304
• [x] announcementcenter (https://github.com/owncloud/announcementcenter/pull/145)
• [x] audit_splunk (https://github.com/owncloud/audit_splunk/pull/111)
• [x] brute_force_protection (https://github.com/owncloud/brute_force_protection/pull/114)
• [x] calendar (no php stan)
• [x] client-updater-server (https://github.com/owncloud/client-updater-server/pull/62)
• [x] configreport (no phpstan)
• [x] contacts (https://github.com/owncloud/contacts/pull/685)
• [x] customgroups (no phpstan)
• [x] data_exporter https://github.com/owncloud/data_exporter/pull/151
• [x] diagnostics (https://github.com/owncloud/diagnostics/pull/55)
• [x] encryption (https://github.com/owncloud/encryption/pull/195)
• [x] enterprise_key (no phpstan)
• [x] files_antivirus (no phpstan)
• [x] files_classifier (no phpstan)
• [x] files_external_dropbox (https://github.com/owncloud/files_external_dropbox/pull/87)
• [x] files_external_ftp (https://github.com/owncloud/files_external_ftp/pull/61)
• [x] files_external_s3 (https://github.com/owncloud/files_external_s3/pull/387)
• [x] files_ldap_home (https://github.com/owncloud/files_ldap_home/pull/29)
• [x] files_lifecycle https://github.com/owncloud/files_lifecycle/pull/223
• [x] files_mediaviewer (no phpstan)
• [x] files_onedrive (https://github.com/owncloud/files_onedrive/pull/93)
• [x] files_paperhive (https://github.com/owncloud/files_paperhive/pull/28)
• [x] files_pdfviewer (https://github.com/owncloud/files_pdfviewer/pull/209)
• [x] files_primary_s3 (https://github.com/owncloud/files_primary_s3/pull/336)
• [x] files_texteditor (https://github.com/owncloud/files_texteditor/pull/314/files)
• [x] firewall (https://github.com/owncloud/firewall/pull/628)
• [x] firstrunwizard (https://github.com/owncloud/firstrunwizard/pull/128)
• [x] guests (https://github.com/owncloud/guests/pull/407) (https://github.com/owncloud/guests/pull/408)
• [x] impersonate (https://github.com/owncloud/impersonate/pull/160)
• [x] market (https://github.com/owncloud/market/pull/551)
• [x] metrics (https://github.com/owncloud/metrics/pull/48)
• [x] notes (no phpstan)
• [x] notifications (https://github.com/owncloud/notifications/pull/306)
• [x] oauth2 (https://github.com/owncloud/oauth2/pull/260)
• [x] objectstore (https://github.com/owncloud/objectstore/pull/113)
• [x] openidconnect (Already running latest)
• [x] ownbrander (no phpstan)
• [x] password_policy (https://github.com/owncloud/password_policy/pull/297)
• [x] phoenix (no phpstan)
• [x] ransomware_protection (https://github.com/owncloud/ransomware_protection/pull/224)
• [x] richdocuments (https://github.com/owncloud/richdocuments/pull/332)
• [x] search_elastic https://github.com/owncloud/search_elastic/pull/167
• [x] sharepoint (no phpstan)
• [x] smb_acl (https://github.com/owncloud/smb_acl/pull/83)
• [x] smb_acl_frontend (no phpstan)
• [x] systemtags_management (https://github.com/owncloud/systemtags_management/pull/62)
• [x] templateeditor (https://github.com/owncloud/templateeditor/pull/115)
• [x] testing (https://github.com/owncloud/testing/pull/141)
• [x] theme-enterprise (no phpstan)
• [x] twofactor_totp (https://github.com/owncloud/twofactor_totp/pull/167)
• [x] user_ldap (https://github.com/owncloud/user_ldap/pull/553)
• [x] user_shibboleth (https://github.com/owncloud/user_shibboleth/pull/295)
• [x] windows_network_drive (no phpstan)
• [x] wopi (https://github.com/owncloud/wopi/pull/88)
• [x] workflow (https://github.com/owncloud/workflow/pull/231)

[phil-davis]

Note: the version of phpstan has been updated to 0.12 in all vendor-bin/phpstan/composer.json

phpstan is only running in some repos, where it was already running or was easy to get passing. It was not the purpose of this issue to actually get it running and passing in every repo.