Run app acceptance tests with PHP 7.4

owncloud / QA

:collision: public test plans for owncloud components and apps

GNU Affero General Public License v3.0

14 stars 17 forks source link

Run app acceptance tests with PHP 7.4 #645

Closed phil-davis closed 4 years ago

phil-davis commented 4 years ago

Make PRs in each app that has acceptance tests to see the results.

run the acceptance tests with PHP 7.4
run against core branch php7.4-20200310 (that has the minimal core changes to enable PHP 7.4 in core)
analyze any test fails and make any needed fixes to test or app code
check the owncloud log of the CI to see if anything unusual is reported

jvillafanez commented 4 years ago

Unit tests:

[x] activity: https://github.com/owncloud/activity/pull/851
[x] admin_audit: nothing found
[x] diagnostics: nothing found
[x] enterprise_key: nothing found
[x] files_external_s3: a bunch of tests skipped, but nothing found
[x] files_primary_s3: make test-php-unit runs all the tests in core. There are errors coming from the apps in core, but nothing specific to files_primary_s3.
[x] market: nothing found
[x] notifications: nothing found
[x] oauth2: nothing found
[x] password_policy: nothing found
[x] richdocuments: nothing found
[x] smb_acl: nothing found
[x] user_ldap: nothing found
[x] user_shibboleth: nothing found
[x] windows_network_drive: https://github.com/owncloud/windows_network_drive/pull/288

Based only on the code executed by the unit tests on the master branch. Acceptance tests haven't been checked. (Some apps might be missing)

phil-davis commented 4 years ago

Acceptance tests:

[x] activity https://github.com/owncloud/activity/pull/850
[x] admin_audit https://github.com/owncloud/admin_audit/pull/313
[x] brute_force_protection https://github.com/owncloud/brute_force_protection/pull/116
[x] configreport https://github.com/owncloud/configreport/pull/129
[x] customgroups https://github.com/owncloud/customgroups/pull/332
[x] data_exporter https://github.com/owncloud/data_exporter/pull/155
[x] encryption https://github.com/owncloud/encryption/pull/190
[x] files_antivirus https://github.com/owncloud/files_antivirus/pull/364
[x] files_classifier https://github.com/owncloud/files_classifier/pull/326
[x] files_lifecycle https://github.com/owncloud/files_lifecycle/pull/229
[x] files_primary_s3 https://github.com/owncloud/files_primary_s3/pull/342
[x] files_texteditor https://github.com/owncloud/files_texteditor/pull/316
[x] firewall https://github.com/owncloud/firewall/pull/629
[x] firstrunwizard https://github.com/owncloud/firstrunwizard/pull/131
[x] guests https://github.com/owncloud/guests/pull/409
[x] impersonate (No acceptance tests)
[x] notifications https://github.com/owncloud/notifications/pull/308
[x] oauth2 https://github.com/owncloud/oauth2/pull/261
[x] password_policy https://github.com/owncloud/password_policy/pull/299
[x] ransomware_protection https://github.com/owncloud/ransomware_protection/pull/226
[x] richdocuments https://github.com/owncloud/richdocuments/pull/334
[x] search_elastic https://github.com/owncloud/search_elastic/pull/169
[x] testing https://github.com/owncloud/testing/pull/143
[x] twofactor_totp https://github.com/owncloud/twofactor_totp/pull/169
[x] user_ldap https://github.com/owncloud/user_ldap/pull/550
[x] windows_network_drive https://github.com/owncloud/windows_network_drive/pull/289
[x] workflow https://github.com/owncloud/workflow/pull/229

phil-davis commented 4 years ago

All are passing with PHP 7.4 - good stuff.