phpunit 8 in app repos

[phil-davis]

PR https://github.com/owncloud/core/pull/37307 bumped phpunit from v7 to v8 in core.

The next daily-master-qa tarball will have phpunit v8. Nightly app CI will run with that.

1) Check for any PHP unit test fails in apps, and fix them 2) In vendor-bin/behat/composer.json bump phpunit to 8.5 3) Check acceptance test app code for uses of PHPUnit\Framework\Assert::assertContains and change to PHPUnit\Framework\Assert::assertStringContainsString when the "haystack" is a string. e.g. https://github.com/owncloud/activity/pull/853

[kiranparajuli589]

This is the list of apps to check:

• [x] activity https://github.com/owncloud/activity/pull/853 https://github.com/owncloud/activity/pull/855
• [x] admin_audit https://github.com/owncloud/admin_audit/pull/317
• [x] announcementcenter
• [x] audit_splunk
• [x] brute_force_protection
• [x] calendar
• [x] client-updater-server
• [x] configreport (https://github.com/owncloud/customgroups/pull/333)
• [x] contacts
• [x] customgroups (https://github.com/owncloud/customgroups/pull/333)
• [x] data_exporter
• [x] diagnostics (https://github.com/owncloud/diagnostics/pull/58)
• [x] encryption (https://github.com/owncloud/encryption/pull/191)
• [x] enterprise
• [x] enterprise_key
• [x] files_antivirus (https://github.com/owncloud/files_antivirus/pull/365)
• [x] files_classifier
• [x] files_external_dropbox
• [x] files_external_ftp
• [x] files_external_s3
• [x] files_ldap_home
• [x] files_lifecycle (https://github.com/owncloud/files_lifecycle/pull/232)
• [x] files_mediaviewer
• [x] files_onedrive
• [x] files_paperhive
• [x] files_pdfviewer
• [x] files_primary_s3 (https://github.com/owncloud/files_primary_s3/pull/344)
• [x] files_texteditor (https://github.com/owncloud/files_texteditor/pull/319)
• [x] firewall (https://github.com/owncloud/firewall/pull/631)
• [x] firstrunwizard (https://github.com/owncloud/firstrunwizard/pull/133)
• [x] guests
• [x] impersonate
• [x] market (https://github.com/owncloud/market/pull/555)
• [x] metrics
• [x] notes
• [x] notifications (https://github.com/owncloud/notifications/pull/310)
• [x] oauth2 (https://github.com/owncloud/oauth2/pull/264)
• [x] objectstore
• [x] openidconnect
• [x] ownbrander
• [x] password_policy (https://github.com/owncloud/password_policy/pull/301)
• [x] phoenix
• [x] ransomware_protection (https://github.com/owncloud/ransomware_protection/pull/228)
• [x] richdocuments
• [x] search_elastic (https://github.com/owncloud/search_elastic/pull/171)
• [x] sharepoint
• [x] smb_acl (https://github.com/owncloud/smb_acl/pull/86)
• [x] smb_acl_frontend
• [x] systemtags_management
• [x] templateeditor
• [x] testing (https://github.com/owncloud/testing/pull/145)
• [x] theme-enterprise
• [x] twofactor_totp https://github.com/owncloud/twofactor_totp/pull/173
• [x] user_ldap (https://github.com/owncloud/user_ldap/pull/553)
• [x] user_shibboleth
• [x] windows_network_drive (https://github.com/owncloud/windows_network_drive/pull/290)
• [x] wopi
• [x] workflow (https://github.com/owncloud/workflow/pull/230)

[phil-davis]

This is done - all app php unit tests are passing.