Use SonarCloud in oC10 app repos

[phil-davis]

core PR https://github.com/owncloud/core/pull/37982 changed from using codecov to SonarCloud for coverage reporting. SonarCloud also provides other automated code analysis.

core PR https://github.com/owncloud/core/pull/37984 made some adjustments to that.

Do similar for oC10 app repos.

Make sure that the starlark code changes can be used consistently in each app, so that we can do general code changes in an example app (e.g. https://github.com/owncloud/data_exporter ) and then it should be "easy" to apply the same code changes to the starlark of the other apps.

[phil-davis]

Note: also see #648 "Reduce CI that is run after merge" - we do not need to always run acceptance tests again when a PR is merged in a app repo. But that can be discussed and done after the SonarCloud changes.

[phil-davis]

Apps to convert next:

• [x] data_exporter (almost done) https://github.com/owncloud/data_exporter/pull/175
• [x] activity (has JS and PHP unit tests, but only PHP unit tests are doing coverage, so should be easy) https://github.com/owncloud/activity/pull/901
• [x] contacts (has JS tests and PHP unit tests and PHP integration tests all with some coverage upload) https://github.com/owncloud/contacts/pull/701

This is the full list of remaining apps:

• [x] admin_audit https://github.com/owncloud/admin_audit/pull/351
• [x] announcementcenter https://github.com/owncloud/announcementcenter/pull/156
• [x] audit_splunk https://github.com/owncloud/audit_splunk/pull/124
• [x] brute_force_protection https://github.com/owncloud/brute_force_protection/pull/143
• [x] calendar https://github.com/owncloud/calendar/pull/1150
• [x] configreport https://github.com/owncloud/configreport/pull/138
• [x] customgroups https://github.com/owncloud/customgroups/pull/379
• [x] diagnostics https://github.com/owncloud/diagnostics/pull/65
• [x] encryption https://github.com/owncloud/encryption/pull/219
• [x] files_antivirus https://github.com/owncloud/files_antivirus/pull/386
• [x] files_classifier https://github.com/owncloud/files_classifier/pull/410
• [x] files_external_dropbox https://github.com/owncloud/files_external_dropbox/pull/98
• [x] files_external_ftp https://github.com/owncloud/files_external_ftp/pull/74
• [x] files_external_s3 https://github.com/owncloud/files_external_s3/pull/535
• [x] files_ldap_home https://github.com/owncloud/files_ldap_home/pull/41
• [x] files_lifecycle https://github.com/owncloud/files_lifecycle/pull/302
• [x] files_onedrive https://github.com/owncloud/files_onedrive/pull/108
• [x] files_paperhive https://github.com/owncloud/files_paperhive/pull/36
• [x] files_pdfviewer https://github.com/owncloud/files_pdfviewer/pull/229
• [x] files_primary_s3 https://github.com/owncloud/files_primary_s3/pull/441
• [x] files_texteditor https://github.com/owncloud/files_texteditor/pull/328
• [x] firewall https://github.com/owncloud/firewall/pull/658
• [x] firstrunwizard https://github.com/owncloud/firstrunwizard/pull/143
• [x] guests https://github.com/owncloud/guests/pull/427
• [x] icap https://github.com/owncloud/icap/pull/8
• [x] impersonate https://github.com/owncloud/impersonate/pull/171
• [x] market https://github.com/owncloud/market/pull/614
• [x] metrics https://github.com/owncloud/metrics/pull/82
• [x] notes https://github.com/owncloud/notes/pull/372
• [x] notifications https://github.com/owncloud/notifications/pull/328
• [x] oauth2 https://github.com/owncloud/oauth2/pull/277
• [x] objectstore https://github.com/owncloud/objectstore/pull/127
• [x] openidconnect https://github.com/owncloud/openidconnect/pull/124
• [x] ownbrander https://github.com/owncloud/ownbrander/pull/951
• [x] password_policy https://github.com/owncloud/password_policy/pull/322
• [x] ransomware_protection https://github.com/owncloud/ransomware_protection/pull/248
• [x] richdocuments https://github.com/owncloud/richdocuments/pull/373
• [x] search_elastic https://github.com/owncloud/search_elastic/pull/189 @phil-davis
• [x] smb_acl https://github.com/owncloud/smb_acl/pull/108
• [x] systemtags_management https://github.com/owncloud/systemtags_management/pull/76
• [x] templateeditor https://github.com/owncloud/templateeditor/pull/124
• [x] testing https://github.com/owncloud/testing/pull/158
• [x] theme-enterprise https://github.com/owncloud/theme-enterprise/pull/88
• [x] twofactor_totp https://github.com/owncloud/twofactor_totp/pull/201
• [x] user_ldap https://github.com/owncloud/user_ldap/pull/603
• [x] user_shibboleth https://github.com/owncloud/user_shibboleth/pull/311
• [x] windows_network_drive https://github.com/owncloud/windows_network_drive/pull/313
• [x] wopi https://github.com/owncloud/wopi/pull/106
• [x] workflow https://github.com/owncloud/workflow/pull/250

We need to apply the starlark code to each of them.

Some apps might not have unit tests. In that case we just apply the starlark code, and the SonarCloud parts will not actually run. I will look for one of those now, because we should do that first to see what happens if there is no unit test coverage report needed.

Needs to be done along with the changes for https://github.com/owncloud/QA/issues/648#issuecomment-735548177 "Reduce CI that is run after merge"

These apps have their own starlark that is very diffferent, and SonarCloud is not-applicable at this stage:

• client-updater-server
• files_mediaviewer

These apps do not have drone CI:

• sharepoint
• twofactor_backup_codes

[phil-davis]

Some small fixes were discovered on 2020-12-07:

• Set env vars to empty strings instead of None - this helps user_ldap to be able to convert its starlark
• Fix sonar.pullrequest.github.repository - that value in sonar-project.properties was still set to owncloud/core. It should be specific to the app, for example ownclud/activity After fixing that, we get SonarCloud analysis posted back to the PRs on GitHub

These fixes need to get applied to each of these app repos:

• [x] activity https://github.com/owncloud/activity/pull/908
• [x] admin_audit
• [x] announcementcenter
• [x] audit_splunk https://github.com/owncloud/audit_splunk/pull/125
• [x] brute_force_protection
• [x] calendar
• [x] configreport
• [x] contacts
• [x] customgroups
• [x] data_exporter
• [x] diagnostics
• [x] encryption
• [x] files_antivirus
• [x] files_classifier
• [x] files_external_dropbox
• [x] files_external_ftp
• [x] files_external_s3
• [x] files_ldap_home
• [x] files_lifecycle
• [x] files_onedrive
• [x] files_paperhive
• [x] files_pdfviewer
• [ ] files_primary_s3
• [x] files_texteditor
• [x] firewall
• [x] firstrunwizard
• [x] guests
• [x] icap
• [x] impersonate
• [x] market
• [x] metrics
• [x] notes https://github.com/owncloud/notes/pull/372
• [x] notifications https://github.com/owncloud/notifications/pull/328
• [x] oauth2 https://github.com/owncloud/oauth2/pull/277
• [x] objectstore https://github.com/owncloud/objectstore/pull/127
• [x] openidconnect https://github.com/owncloud/openidconnect/pull/124
• [x] ownbrander https://github.com/owncloud/ownbrander/pull/951
• [x] password_policy https://github.com/owncloud/password_policy/pull/322
• [x] ransomware_protection https://github.com/owncloud/ransomware_protection/pull/248
• [x] richdocuments https://github.com/owncloud/richdocuments/pull/373
• [x] search_elastic
• [x] smb_acl
• [x] systemtags_management https://github.com/owncloud/systemtags_management/pull/76
• [x] templateeditor https://github.com/owncloud/templateeditor/pull/124
• [x] testing
• [x] theme-enterprise
• [x] twofactor_totp https://github.com/owncloud/twofactor_totp/pull/201
• [x] user_ldap https://github.com/owncloud/user_ldap/pull/603
• [x] user_shibboleth https://github.com/owncloud/user_shibboleth/pull/311
• [x] windows_network_drive https://github.com/owncloud/windows_network_drive/pull/313
• [x] wopi https://github.com/owncloud/wopi/pull/106
• [x] workflow https://github.com/owncloud/workflow/pull/250

[phil-davis]

ToDo:

• [x] https://github.com/owncloud/graphapi - PR https://github.com/owncloud/graphapi/pull/10

[phil-davis]

files_primary_s3 is remaining. I assigned myself. I want to get this finished today!

[phil-davis]

PR https://github.com/owncloud/files_primary_s3/pull/441 is ready for review. That is the last item for this issue. When it is merged, please close this issue.