[QA] Check for lint issues in test feature files

[grgprarup]

Check and make a fix PR for the lint issues in acceptance, and e2e test feature files. Gherlinter offers a configuration option to set rules, which can be found at https://github.com/gherlint/gherlint?tab=readme-ov-file#configuration. Some of the rule sets default to warn and to throw an error. When using Gherlint, it's important to make sure that the configuration aligns with the standard for our organization.

Objectives:

• Maintain consistency across all feature files
• Reduce peer review workload (formatting will be handled by the linter)

To Do:

• Add a pipeline for linting the feature file using gherlint. point to note mentioned in this comment https://github.com/owncloud/QA/issues/833#issuecomment-2160005192

  • [x] ocis @prashant-gurung899 https://github.com/owncloud/ocis/pull/9503
  • [ ] web (need to research on gherlint configuration to set rules according to our standard)
  • [x] client https://github.com/owncloud/client/pull/11796

• check for lint issues in feature files

  • [ ] web ( linter cannot be used since the feature files does not follow standard gherkin steps ) but manipulating configuration can work
  • [x] ocis @prashant-gurung899 https://github.com/owncloud/ocis/pull/9343
  • Two when on scenario- Sharer can download file uploaded with different permission by sharee to a shared folder
  • [x] core https://github.com/owncloud/core/pull/41251
  • [x] client https://github.com/owncloud/client/pull/11796
  • [ ] other apps

Tools to use:

• gherlint linter (https://github.com/gherlint/gherlint) ~Note: The linter is in its beta version, so the auto fix might not properly work, you might need a manual fix for that.~

[nirajacharya2]

It would be nice to do the linting in CI. Should we add that to the task list? CC @saw-jan

[saw-jan]

It would be nice to do the linting in CI. Should we add that to the task list? CC @saw-jan

yes, we can have a ci pipeline. but I want to have test code check pipelines in one single pipeline if possible.

[PrajwolAmatya]

The gherlint has been implemented in ocis, core and client. For now, the gherlint will not be implemented on other projects. So, closing this issue as completed.