Open reverendus7 opened 6 months ago
as a quick temporary fix, we modified the SendEmails.php
file, in the execute
method like this:
//do {
$users = $this->mqHandler->getAllUsers(self::BATCH_SIZE);
$batchCount = \count($users);
if ($batchCount === 0) {
// queue is empty
//break;
return 0;
}
$this->sendBatch($users, $output);
if ($progress !== null) {
$progress->advance($batchCount);
}
//} while ($batchCount > 0);
In this way, we try to send emails only once per cron run
Steps to reproduce
Expected behaviour
There should not be infinite tries in re-sending failed emails.
Actual behaviour
The infinite loop in trying to send emails is making log file huge. Using a cron for sending emails makes it even worse. It also has impact on cpu usage since the script never ends (and new scripts are launched every-time the cron requires).
Server configuration
ownCloud version: 2.7.2
Logs
ownCloud log (data/owncloud.log)