search

owncloud / activity

:zap: Activity app for ownCloud
33 stars 40 forks source link

activity app does not pass occ app:check-code #282

Closed jnfrmarks closed 9 years ago

jnfrmarks commented 9 years ago

Steps to reproduce

  1. Install 8.1 enterprise
  2. invoke occ app:check-code

    Expected behaviour

The app passes the check

Actual behaviour

The app fails the check:


Analysing /var/www/html/owncloud/apps/activity/tests/datadeleteactivitestest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/usersettingstest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/mailqueuehandlertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/mock/extension.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/apitest.php
 6 errors
    line   38: OC_User - static method call on private class
    line   39: OC_User - static method call on private class
    line   85: OC_User - static method call on private class
    line   89: OC_User - static method call on private class
    line  148: OC_User - static method call on private class
    line  149: OC_User - static method call on private class
Analysing /var/www/html/owncloud/apps/activity/tests/applicationtest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/parameterhelpertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/navigationtest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/hooksdeleteusertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/datatest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/datahelpertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/controller/activitiestest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/controller/settingstest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/controller/feedtest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/apptest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/personaltest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/consumertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/displaytest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/grouphelpertest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/backgroundjob/expireactivitiestest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/backgroundjob/emailnotificationtest.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/testcase.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/tests/bootstrap.php
 1 errors
    line   16: OC_Hook - static method call on private class
Analysing /var/www/html/owncloud/apps/activity/personal.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/personal.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/stream.item.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/rss.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/stream.body.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/email.notification.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/stream.app.navigation.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/templates/stream.list.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/extension/files_sharing.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/extension/files.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/controller/feed.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/controller/settings.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/controller/activities.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/navigation.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/parameterhelper.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/consumer.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/data.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/api.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/mailqueuehandler.php
 1 errors
    line  249: OC_Helper - static method call on private class
Analysing /var/www/html/owncloud/apps/activity/lib/grouphelper.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/hooks.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/fileshooksstatic.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/fileshooks.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/usersettings.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/backgroundjob/emailnotification.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/backgroundjob/expireactivities.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/datahelper.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/lib/display.php
 2 errors
    line   93: OC_Helper - static method call on private class
    line  105: OC_Helper - static method call on private class
Analysing /var/www/html/owncloud/apps/activity/appinfo/app.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/appinfo/routes.php
 1 errors
    line   27: OC_API - static method call on private class
Analysing /var/www/html/owncloud/apps/activity/appinfo/update.php
 0 errors
Analysing /var/www/html/owncloud/apps/activity/appinfo/application.php
 0 errors
App is not compliant

Server configuration

Ubuntu 14.04 PHP 5.5.9 ownCloud Enterprise Edition 8.1 alpha 1 (daily) Build:2015-04-16T03:08:13+00:00 f50798a674bf223e1c8015b9a27287b2ac6c9f1a

nickvergessen commented 9 years ago

Yes, but it's mostly the tests and FilesView. FilesView will be dealt with in #249 for 8.2, the tests don't matter too much.

Will look at the other stuff soon

nickvergessen commented 9 years ago

Tests have been excluded now https://github.com/owncloud/core/pull/15838 so the activity app passes again

bcutter commented 9 years ago

Hi, when running "sudo -u www-data php /var/www/owncloud/occ app:check-code activity" I get:

"Analysing /var/www/owncloud/apps/activity/lib/display.php 1 errors line 94: OC_Helper - static method call on private class App is not compliant"

==> ???

OC v8.1.1 Activity v2.0.1

nickvergessen commented 9 years ago

Yeah can't really fix that without breaking previews in 8.1 You will have to live with that until 8.2 is out