search

owncloud / activity

:zap: Activity app for ownCloud
33 stars 40 forks source link

Activities from other files are visible even if "Limit activities for favorites" is ticked #687

Open skshetry opened 5 years ago

skshetry commented 5 years ago
### Steps to reproduce 1. Enable "Limit notifications about creation and changes to your favorite files" from General Settings page. 2. Add a tag or comment on any file/folder that is not favorited. 3. Check activity log from the webUI ### Expected behaviour Log should be there mentioning creation of comment or assignment of tag. ### Actual behaviour No log related to step 2. Disabling the limit, and again checking the logs does show up the log related to step 2. So, the log is being generated but not visible. Filtering log by "Comments" or "Tags" does show up the log, and is also visible on the sidebar. Only in the default view, it is not displayed.
pmaier1 commented 5 years ago

Well, this works as designed, I'd say. Why would you expect to see entries for not favorited files if you explicitly configure it to only show entries for favorited files?

The term "notifications" might be misleading here as it's actually the configuration for the Activity app and the digest mails it sends.

Anyway, I can't see the benefit of this option as you can simply filter by favorites in the activity app itself and the option only refers to the activity stream, not the digest mails. screenshot from 2019-01-25 11-55-44

Any clue? @PVince81 maybe?

pmaier1 commented 5 years ago

Well, the "Favorites" filter doesn't seem to work properly as I have no favorites set at all in my account but still see a lot of entries -_- WTF.

phil-davis commented 5 years ago

"Limit notifications about creation and changes to your favorite files"

In English I have trouble understanding exactly what this sentence should mean: 1) "Limit notifications about creation and changes to only be shown for files that you have favorited" or 2) "Do not show notifications about creation and changes for files that you have favorited" (and also, why does it explicitly just say "creation and changes" - probably this is meant to apply to all "file and file meta-data events", which also means rename, delete, tag add/remove, comment add/remove/edit...)

Probably the intention is (1)?

After deciding that (1) is the requirement, then the question is how are the activity notifications are expected to be limited: a) Just hidden on webUI, but they have still actually all been logged in the backend and so there is the potential to re-display them in the future b) The "limited" activity events are not logged at all, so there is no way in future to see them c) What is expected to happen for any other "backend" functionality, e.g. if activity events are being "sent somewhere" (another logging backend, emails to somewhere, whatever...) - are those things supposed to happen or not for the acctivity events that have been "limited"

If the high-level requirements are written down, then we can write test scenarios for them (or the person writing the high-level requirements can write example test scenarios...)

skshetry commented 5 years ago

@phil-davis I thought it to be 2. Even if it is 1, the logs are still generated (for changes/creation/deletion), but not for tags/comments.

PVince81 commented 5 years ago

this option was introduced with https://github.com/owncloud/activity/pull/271 and https://github.com/owncloud/core/pull/15196#issuecomment-88136304

not sure about the exact design decision

skshetry commented 5 years ago

I thought the option was related to limiting activities from favorited files (idk why that came to me). But, still, other files (not favorited ones) are still shown in the activity. So, I'll rename the issue title.