Possible Code refactorings

[theScrabi]

I've worked on the android app code for a little while now, and found some code which could be refactored or even removed. Here is my list:

Things to DELETE

Classes not in use anymore

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/NavigationDrawerItem.java#L23-L23

• [x] https://github.com/owncloud/android/blob/14a2b28788e2e61d5b3e94b11234091cb9680e22/src/com/owncloud/android/ui/dialog/ChangelogDialog.java#L36

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/dialog/UploadSourceDialogFragment.java#L43-L43

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/dialog/SslValidatorDialog.java#L53

• [x] https://github.com/owncloud/android/blob/f3f52a89742ac96ce69c4f3080c86871859d04b9/src/com/owncloud/android/files/services/FileUploader.java#L193-L195

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/files/services/OnUploadCompletedListener.java#L23

• [x] This class seems important, however it's not in use: https://github.com/owncloud/android/blob/0cb666d67f8ec9b8fc5a175538114e7bd0713998/src/com/owncloud/android/services/observer/RecursiveFolderObserver.java#L30-L30

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/adapter/GroupAdapter.java#L21-L33

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/adapter/LogListAdapter.java#L21-L74

• [x] These two classes seem to not be used anymore, so both, and the package thire in can be removed: https://github.com/owncloud/android/blob/ee85bf9e8c2dce2855c227a5e79b41aeeadd0e6f/src/com/owncloud/android/ui/dialog/parcel/MenuParcelable.java#L21-L51 https://github.com/owncloud/android/blob/a46eb270ab72e28001f1b1264e5b4bda466f1adc/src/com/owncloud/android/ui/dialog/parcel/MenuItemParcelable.java#L21-L61

• [x] Lol https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/fragment/AuthenticatorAccountDetailsFragment.java#L21-L27

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/QuickAction.java#L67-L90

  • [x] lol nr. 2 https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/fragment/AuthenticatorGetStartedFragment.java#L21-L27

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/utils/DialogMenuItem.java#L21-L247

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/utils/UploadUtils.java#L21-L53

• [x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/RadioButtonPreference.java#L21-L39

Methods not in use anymore

• [x] https://github.com/owncloud/android/blob/292feb1dae980c68b4375078e252d218bee4b7f3/src/com/owncloud/android/authentication/AccountAuthenticator.java#L322-L339
• [WON'T BE DELETED, IT MAKES SENSE TO KEEP THEM] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/adapter/DiskLruImageCache.java#L144-L173
• [ ] https://github.com/owncloud/android/blob/0ad8492a7e1baa83231a33deea70a827b3bfe801/src/com/owncloud/android/broadcastreceivers/ConnectivityActionReceiver.java#L202-L226
• [x] https://github.com/owncloud/android/blob/1b482c3b9596600feced2696b497608ab5a92b39/src/com/owncloud/android/features/FeatureList.java#L89-L91
• [wont fix because it may make sense to keep it here] https://github.com/owncloud/android/blob/ceb1265808f518ece5d83fd8f450fb3f08905bab/src/com/owncloud/android/services/OperationsService.java#L778-L788
• [x] https://github.com/owncloud/android/blob/f89195b0d62c10da9fb98c136b865dbde114e3ed/src/com/owncloud/android/ui/activity/Preferences.java#L762-L764
• [ ] https://github.com/owncloud/android-library/blob/11363adedb00211c321ba7ed2db8dd1fcc2421c9/src/com/owncloud/android/lib/common/network/AdvancedSslSocketFactory.java#L104-L142
• [ ] https://github.com/owncloud/android-library/blob/e466bac6b15336983340e8b2c552a88423a06264/src/com/owncloud/android/lib/common/SimpleFactoryManager.java#L71-L80

Things to REFACTOR

• [x] Public declaration in several interfaces can be removed, since interface methods are always public.
• [x] Actively converting UI elements is not necessary anymore. This these can be Removed. Like here
• [x] These lines can be simplified https://github.com/owncloud/android/blob/4a1ce06eed62c771460c5070f42d1a18624191b2/src/com/owncloud/android/datamodel/FileDataStorageManager.java#L1087-L1096
• [x] DELETE unused imports like here
• [x] these two functions can be reduced to one big, and one small. Also we should consider to remove them since they are not in use: https://github.com/owncloud/android/blob/77483212ee8ee62b7b49ca42723de136fb0e1f24/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java#L611-L647
• [ ] FutureList has a package for it's own. Maybe it can be moved somewhere else.
• [x] Lets do something or remove this: https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/media/MediaControlView.java#L93-L193
• [x] Remove commends: https://github.com/owncloud/android/blob/fa4b5bc5ebd649f9902814871655f842532566f0/src/com/owncloud/android/providers/FileContentProvider.java#L253-L303
• [ ] OnEnorceableRefreshListener can be embeded into ExtendedListFragment
• [x] Enum does not need to be static https://github.com/owncloud/android/blob/3ba849d4311e2c53527b77a6e113cac2da2e2a1f/src/com/owncloud/android/ui/dialog/ConflictsResolveDialog.java#L42-L47
• [x] ifles can be replaces with switch statements https://github.com/owncloud/android/blob/426bfefe9db7f1ad4aea47a03cc1009bf1e2323e/src/com/owncloud/android/ui/errorhandling/ErrorMessageAdapter.java#L21-L481
• [x] Replace all this getter functions with simple findActionById() calls or final object declarations https://github.com/owncloud/android/blob/c41092aa5fc3e69c17a4c7f6e320b2692e2af4fa/src/com/owncloud/android/ui/fragment/PublicShareDialogFragment.java#L742-L824
• [ ] Should be moved into the utils package https://github.com/owncloud/android/blob/7132c10103085e74e01c1516b3e626eab1315890/src/com/owncloud/android/ui/notifications/NotificationUtils.java#L21-L74
• [x] Do we still need this? If it was important for us later we could still checkout a n older version of the app, so I would vote for no. https://github.com/owncloud/android/blob/9b403198112360034e1e51c79fa6bdbec4ddc5aa/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java#L245-L395
• [x] Remove all the new lines https://github.com/owncloud/android/blob/e02c685229c873bf20c6d90a77e31c874fd8b2a5/src/com/owncloud/android/ui/preview/PreviewVideoErrorAdapter.java#L51-L78
• [x] Method should call super https://github.com/owncloud/android/blob/a194762e3e3046d79a2ec9909760a7a5a99dd117/src/com/owncloud/android/ui/preview/PreviewVideoFragment.java#L603-L606
• [ ] Class should not have its own package https://github.com/owncloud/android/blob/1b482c3b9596600feced2696b497608ab5a92b39/src/com/owncloud/android/ui/whatsnew/ProgressIndicator.java#L38-L38
• [x] Should use AppCombatImageView https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/SquareImageView.java#L26-L26
• [x] If/else can be replaced by switch https://github.com/owncloud/android/blob/a0d371450c5b74c9842c0d9ff83102b80a363b18/src/com/owncloud/android/utils/BitmapUtils.java#L138-L174
• [nofix] Class can be replaced by the two lines it contains ... actually thinking about this twice it makes sense to have this class https://github.com/owncloud/android/blob/9d3d42da17cdf67ce45aca010325bad3881a1f6c/src/com/owncloud/android/utils/PowerUtils.java#L20-L34
• [x] Should be replaced by AppCombatEditText https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/widgets/ActionEditText.java#L38-L38
• [ ] Exceptions can be removed https://github.com/owncloud/android-library/blob/11363adedb00211c321ba7ed2db8dd1fcc2421c9/src/com/owncloud/android/lib/common/network/AdvancedSslSocketFactory.java#L158-L162
• [ ] Can be replaces by switch case https://github.com/owncloud/android-library/blob/ee726119cb21ac07c17857cb1a81baa262bf42da/src/com/owncloud/android/lib/resources/shares/ShareXMLParser.java#L296-L369
• [ ] @davivel according to git anode you added it, but what is the purpose of this class? https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/activity/HookActivity.java#L21-L26
• [ ] remove unnecessary commends https://github.com/owncloud/android/blob/master/src/com/owncloud/android/ui/fragment/PublicShareDialogFragment.java#L193-L361

Need despaget

• [ ] https://github.com/owncloud/android/blob/8469e99628e8f77522de9fdad763c384266be079/src/com/owncloud/android/operations/GetUserProfileOperation.java
• [ ] https://github.com/owncloud/android/blob/2d7b9bfa10801c1fc1250f621fb248f448b78f36/src/com/owncloud/android/operations/RemoveFileOperation.java

[theScrabi]

Also we might want to consider to upgrade to Java 8 since that comes very in handy with lambda expressions, which is good because less ugly Java code -> better readable.

[dutta14]

I can work on this if it has not been taken up yet.

[theScrabi]

@dutta14 if you like go ahead :)