Open theScrabi opened 6 years ago
Also we might want to consider to upgrade to Java 8 since that comes very in handy with lambda expressions, which is good because less ugly Java code -> better readable.
I can work on this if it has not been taken up yet.
@dutta14 if you like go ahead :)
I've worked on the android app code for a little while now, and found some code which could be refactored or even removed. Here is my list:
Things to DELETE
Classes not in use anymore
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/NavigationDrawerItem.java#L23-L23
[x] https://github.com/owncloud/android/blob/14a2b28788e2e61d5b3e94b11234091cb9680e22/src/com/owncloud/android/ui/dialog/ChangelogDialog.java#L36
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/dialog/UploadSourceDialogFragment.java#L43-L43
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/dialog/SslValidatorDialog.java#L53
[x] https://github.com/owncloud/android/blob/f3f52a89742ac96ce69c4f3080c86871859d04b9/src/com/owncloud/android/files/services/FileUploader.java#L193-L195
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/files/services/OnUploadCompletedListener.java#L23
[x] This class seems important, however it's not in use: https://github.com/owncloud/android/blob/0cb666d67f8ec9b8fc5a175538114e7bd0713998/src/com/owncloud/android/services/observer/RecursiveFolderObserver.java#L30-L30
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/adapter/GroupAdapter.java#L21-L33
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/adapter/LogListAdapter.java#L21-L74
[x] These two classes seem to not be used anymore, so both, and the package thire in can be removed: https://github.com/owncloud/android/blob/ee85bf9e8c2dce2855c227a5e79b41aeeadd0e6f/src/com/owncloud/android/ui/dialog/parcel/MenuParcelable.java#L21-L51 https://github.com/owncloud/android/blob/a46eb270ab72e28001f1b1264e5b4bda466f1adc/src/com/owncloud/android/ui/dialog/parcel/MenuItemParcelable.java#L21-L61
[x] Lol https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/fragment/AuthenticatorAccountDetailsFragment.java#L21-L27
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/QuickAction.java#L67-L90
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/utils/DialogMenuItem.java#L21-L247
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/utils/UploadUtils.java#L21-L53
[x] https://github.com/owncloud/android/blob/988375a8bb46e608111205d9c2fac06f455ba22e/src/com/owncloud/android/ui/RadioButtonPreference.java#L21-L39
Methods not in use anymore
Things to REFACTOR
findActionById()
calls orfinal
object declarations https://github.com/owncloud/android/blob/c41092aa5fc3e69c17a4c7f6e320b2692e2af4fa/src/com/owncloud/android/ui/fragment/PublicShareDialogFragment.java#L742-L824Need despaget