owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.82k stars 3.05k forks source link

Pause manual upload when wifi is off. #2316

Open daylightsports opened 5 years ago

daylightsports commented 5 years ago

Actual behaviour

-Manual upload does not pause when wifi is disconnected or turned off. There is no option to change this behaviour. This is different to auto-upload, which does have wifi/charging option.

Expected behaviour

-We need an option to pause upload when wifi is off.

Environment data

Android version: 9

Device model: pixel 2 xl

Stock or customized system:stock

ownCloud app version2.9 beta 1

ownCloud server version:10.0.10.4

PR

davigonz commented 5 years ago

Hi @daylightsports , thanks for reporting this, do you mean that the upload keeps running using your cellular data once there's no wifi connection?

daylightsports commented 5 years ago

Yes that's what happened. Tim

On 19 October 2018 00:06:42 David González Verdugo notifications@github.com wrote:

Do you mean that the upload keeps running using your cellular data once there's no wifi connection? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 5 years ago

I will fix it.

davigonz commented 5 years ago

I will fix it.

Go for it @BigAdam2005 , if you need any help please ping me.

ghost commented 5 years ago

I have fixed it.

shashvat-kedia commented 5 years ago

@jesmrec Is this still required?

michaelstingl commented 5 years ago

@sd1998 Yes, would be awesome!

There was an attempt not very long ago, but I don't know the status: https://github.com/owncloud/android/pull/2398 /cc @davigonz @jesmrec

jesmrec commented 5 years ago

We reviewed such PR but was not clear by the contributor, what the fix was doing.

shashvat-kedia commented 5 years ago

@jesmrec I would like to work on this.

jesmrec commented 5 years ago

go ahead, but please, do not forget other open PRs like https://github.com/owncloud/android/pull/2400