[FEATURE REQUEST] New account management

abelgardep commented 4 years ago

Next step of #2742

AC:

Account management will be moved from drawer to toolbar, on the top right.
We will see the avatar of the current account
When we click on that thumbnail, a dialog will appear.
We will be able to see all accounts in oC app, lock account, delete account.
Every account will show the display name and below the username@server
In case multiaccount is enabled (this is by default), there will be an option to create a new account, that prompts to login view
An option to edit an account will be available. It will point to login view, sending URL to fill up there. URL must be disabled, only available a password change.

Old account handling	New account handling

TASKS

[ ] Research (if needed)
[ ] Create branch feature/feature_name
[ ] Development tasks
- [ ] Implement whatever
- [ ] ...
[ ] Code review and apply changes requested
[ ] Design test plan
[ ] QA
[ ] Merge branch feature/feature_name into master

PR

App
Library (if needed)

abelgardep commented 4 years ago

AC to discuss

Will be this thumbnail visible only at root folder? (Related with https://github.com/owncloud/android/issues/2847)
What happens with Uploads view? Currently there is menu in that position, should that menu be moved to a similar menu in uploads list view? https://github.com/owncloud/android/issues/2848)
Should we add something like app_name to drawer header? it may feels empty only showing the background image
Should we show the Quota of every account in that dialog?

jesmrec commented 4 years ago

Will be this thumbnail visible only at root folder? (Related with #2847)

What would get the slot in case of non-root folder? a longer search bar?

What happens with Uploads view? Currently there is menu in that position, should that menu be moved to a similar menu in uploads list view? #2848)

I'd set two different menus here, splitting the current one: one for cleaning the list, and other one for manually retries. Setting a bar just above the list sounds a good option.

3 Should we add something like app_name to drawer header? it may feels empty only showing the background image

But, this is the behaviour right now, isn't it? in the drawer header we are showing the accounts and nothing else.

Should we show the Quota of every account in that dialog?

It is also a good option, showing the quota just below the username. But keeping the current place is not bad either. Open to more discussion.

ChrSchultz commented 3 years ago

I wish annother possibility to add an account via Url like:

oc://login/user:<username>&password:<app-passwd>&server<server-url>

abelgardep commented 3 years ago

I wish annother possibility to add an account via Url like:
oc://login/user:<username>&password:<app-passwd>&server<server-url>
There is a problem with that approach. We need to check server status first to check which authentication methods are available. Maybe with basic authentication it would be possible but not with oAuth or OIDC. Thanks for the suggestion anyway 👍

ChrSchultz commented 3 years ago

It only works with the app-password, generated with owncloud. So it would be possible to get the url via qrcode from the server...and import the acc direct by scanning the qrcode.--Christoph Schultz Stütensen 229571 Rosche e-mail: ic-schultz@gmx.de

Am 26.10.20, 09:58 schrieb "Abel García de Prada" notifications@github.com:

I wish annother possibility to add an account via Url like: oc://login/user:&password:&server

There is a problem with that approach. We need to check server status first to check which authentication methods are available. Maybe with basic authentication it would be possible but not with oAuth or OIDC. Thanks for the suggestion anyway 👍 —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

jesmrec commented 3 years ago

It only works with the app-password, generated with owncloud. So it would be possible to get the url via qrcode from the server...and import the acc direct by scanning the qrcode.--Christoph Schultz Stütensen 229571 Rosche e-mail: ic-schultz@gmx.de Am 26.10.20, 09:58 schrieb "Abel García de Prada" notifications@github.com: I wish annother possibility to add an account via Url like: oc://login/user:&password:&server There is a problem with that approach. We need to check server status first to check which authentication methods are available. Maybe with basic authentication it would be possible but not with oAuth or OIDC. Thanks for the suggestion anyway 👍 —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

Please, open a new ticket with the suggested new feature. In the current ticket, we will discuss about UI/UX. Thanks!!

CarolinaCst commented 3 years ago

I) Account Management

As described above, the new account will be located on the right corner in a form of an avatar.
In this section users would be able to mange or add another account.
One of the most outstanding examples is Google Drive

Initially an extended top bar is display showing the name, email and photo of the user.

While navigating and scrolling the extended top bar becomes a regular one. There are different sections in this part like: Home, personal info, Data & personalization, etc.
A modal drawer side menu is also found in Google Drive. Relevant actions like: Recent, Offline and Trash are found in this section.