search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.82k stars 3.05k forks source link

Remove Usecases from Presentation layer #3405

Open theScrabi opened 3 years ago

theScrabi commented 3 years ago

We should stay with the MVVM concept once we decided for it.Therefore we should find a way to remove the UI dependencies in the UseCases which are currently located in our presentation layer. They must be put into the domain layer instead: https://github.com/owncloud/android/tree/master/owncloudApp/src/main/java/com/owncloud/android/usecases

abelgardep commented 3 years ago

This is a good point that needs some research.

Context

At the moment we only have 3 use cases in the presentation layer. All of them are related to uploads because we use the WorkManager to perform the camera uploads. In those workers, some notifications are triggered and string resources are needed. That's why I decided to add them to the presentation layer. I agree that use cases belong to the domain layer but in this case, it was not easy at all. We need to check how to get it.

jesmrec commented 2 years ago

Solution: move all resources, strings etc.. to a separate module.