search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.81k stars 3.05k forks source link

[FEATURE REQUEST] Fix endpoint for "Open in web" #4008

Closed JuancaG05 closed 1 year ago

JuancaG05 commented 1 year ago

Comes from https://github.com/owncloud/android/pull/3990#issuecomment-1488893551.

When implementing "Open in web" for specific providers, we realised that a server instance (https://ocis.ocis-wopi.latest.owncloud.works) couldn't open files, and this could be due to not using the correct endpoint.

The idea here is changing the open-in-web endpoint from https://ocis.ocis-wopi.latest.owncloud.works/app/open-with-web (the one we use currently) to https://ocis.ocis-wopi.latest.owncloud.works/app/open to align also with the iOS client.

Doc: https://github.com/owncloud/ocis/blob/7ef7a60d710f2ac582a64417c03b0f0f4336261d/docs/services/app-registry/apps.md#open-a-file-with-the-owncloud-web

abelgardep commented 1 year ago

Interesting discussion about the open in web feature in the Desktop client https://github.com/owncloud/client/issues/9724#issuecomment-1196675038

JuancaG05 commented 1 year ago

Finally, the endpoint is NOT going to be changed. The problem was a server-related bug, whose fix was not deployed yet. After deploying it, everything seems to work with the open-with-web endpoint.

More info: https://github.com/owncloud/web/issues/8773

jesmrec commented 1 year ago

Then, it's done. Will do another round in regression stage