owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.81k stars 3.05k forks source link

[FEATURE REQUEST] Download log files to device #4205

Closed Aitorbp closed 10 months ago

Aitorbp commented 10 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4155

QA

https://github.com/owncloud/android/pull/4205#issuecomment-1792110218

jesmrec commented 10 months ago

QA checks

jesmrec commented 10 months ago

(1) [FIXED]

If device does not have any app to show downloads content, it crashes. Check this in a device without it:

  1. Open Settings > Logging > Log files
  2. Click on down arrow of any log file to download
  3. Click on Go to downloads

Current: app crashes

Process: com.owncloud.android.debug, PID: 29452
                                                                                                    android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW_DOWNLOADS }
                                                                                                        at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2067)
                                                                                                        at android.app.Instrumentation.execStartActivity(Instrumentation.java:1727)
                                                                                                        at android.app.Activity.startActivityForResult(Activity.java:5320)
                                                                                                        at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:712)
                                                                                                        at android.app.Activity.startActivityForResult(Activity.java:5278)
                                                                                                        at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:693)
                                                                                                        at android.app.Activity.startActivity(Activity.java:5664)
                                                                                                        at android.app.Activity.startActivity(Activity.java:5617)
                                                                                                        at com.owncloud.android.presentation.logging.LogsListActivity.showDownloadDialog$lambda$3(LogsListActivity.kt:159)
                                                                                                        at com.owncloud.android.presentation.logging.LogsListActivity.$r8$lambda$DVmW-XLfGnzR9SFJmPO0udbjbZ4(Unknown Source:0)
                                                                                                        at com.owncloud.android.presentation.logging.LogsListActivity$$ExternalSyntheticLambda0.onClick(Unknown Source:2)
                                                                                                        at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
                                                                                                        at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                        at android.os.Looper.loop(Looper.java:223)
                                                                                                        at android.app.ActivityThread.main(ActivityThread.java:7656)
                                                                                                        at java.lang.reflect.Method.invoke(Native Method)
                                                                                                        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                                                                                                        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Expected: No crash, a warning or snackbar instead.

Pixel 2 Android 11 76ed263d

jesmrec commented 10 months ago

Approved on my side