search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.81k stars 3.05k forks source link

[FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link #4212

Closed manuelplazaspalacio closed 9 months ago

manuelplazaspalacio commented 10 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4194

QA

jesmrec commented 9 months ago

Starting QA...

jesmrec commented 9 months ago

(1) [FIXED]

Open files in root of oC10 does not work for me. Tested with two different servers, getting Unknown error or The user doesn't have access to the file

Files pointed are stored in the root folder of oC10 account (that means, already discovered) and they are already downloaded.

https://github.com/owncloud/android/assets/14894746/e5df9929-d05e-4e2f-b139-01a018107fbc

Pixel 2 Android 11 c3bb396b5

jesmrec commented 9 months ago

(2) [WONT FIX]

When there are some accounts in the device, the way to check which account is the pointed file in, is checking whether the file id exists in an account.

But, is posible that two accounts on the device have a file with the same id (likely in oC10 that is numerical) . In that case, link is not correctly solved.

Pixel 2 Android 11 c3bb396b5

michaelstingl commented 9 months ago

(2)

But, is posible that two accounts on the device have a file with the same id (likely in oC10 that is numerical) . In that case, link is not correctly solved.

Coordinate with iOS team, then maybe document behaviour.

JuancaG05 commented 9 months ago

@jesmrec (1) should be fixed, (2) won't be fixed now, and it also works now for servers that include /index.php in their URL. We use now the meta endpoint (/remote.php/dav/meta/) for oC10 as well.

jesmrec commented 9 months ago

(3)

Behaviour against lack of connection is not correct:

Lack of connection should affect only if the item has not been discovered yet, or if it is not downloaded showing the Details view.

jesmrec commented 9 months ago

(4)

Current iteration is not working with links against shared items (mountpoint drives). Just against personal and project drives.

@michaelstingl is this OK ftm, or is also required for 4.2 (beta.1 or official)?

michaelstingl commented 9 months ago

@michaelstingl is this OK ftm, or is also required for 4.2 (beta.1 or official)?

Okay as "known limitation" for the beta1 I'd say 👍

jesmrec commented 9 months ago

(3) and (4) will be addressed in different issues, so this is approved with restrictions: