owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.84k stars 3.05k forks source link

[FEATURE REQUEST] OCIS: Auto Upload to other space that is not Personal #4214

Closed Aitorbp closed 11 months ago

Aitorbp commented 11 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4117

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/Auto%20Uploads%20to%20Space.md

Reports:

jesmrec commented 11 months ago

(1) [FIXED]

  1. Fresh install
  2. Add oC10 account
  3. Add oCIS account
  4. Enter in Settings and enable Auto Uploads (oCIS account setup by default because it was the last one to be added)
  5. Click on Account to upload path and select the oC10 account
  6. Click on Picture upload path and select a different path

Current: null: in subtitle of the Picture upload path Expected: just the path

Pixel2 Android11 2f0f9b5cb9

jesmrec commented 11 months ago

(2) [WONT FIX]

  1. Install v4.1.1 in device
  2. Add an oCIS account
  3. Enable auto uploads and select any folder as upload path
  4. Update to the current version (migration)

Current: upload path without Personal: subtitle Expected: after migrating to the new version, oCIS accounts should mark the upload path with the space, not only the path. As the previous version only allows to set a path on the personal space, the upload path subtitle should be Personal: <path>

Pixel2 Android11 7341fb015

jesmrec commented 11 months ago

(2) is not an issue. Local branching mess on my side.

jesmrec commented 11 months ago

About the report (1), i still see the null in the oC10 accounts. If i switch from oCIS to oC10 and change the path, it appears again:

https://github.com/owncloud/android/assets/14894746/52d1144d-4abe-4082-8235-9b18fe8e3f02

tested with 2f0f9b5cb

Aitorbp commented 11 months ago

About the report (1), i still see the null in the oC10 accounts. If i switch from oCIS to oC10 and change the path, it appears again:

Screen_recording_20231128_083250.mp4 tested with 2f0f9b5cb

Try with this 5761b2dd59fcea48cc54bd05bc94129a61397780

jesmrec commented 11 months ago

Try with this 5761b2dd59fcea48cc54bd05bc94129a61397780

not reproducible anymore with that commit. Fixed then

jesmrec commented 11 months ago

Approved! ready to go!