owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.79k stars 3.05k forks source link

[FEATURE REQUEST] Don't redact auth type HTTP request logging #4257

Closed JuancaG05 closed 8 months ago

JuancaG05 commented 8 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4249

QA

JuancaG05 commented 8 months ago

When using the MDM parameter, if logs are already enabled, we need to disable and re-enable them again for this option to work properly. This is because we cannot perform an active listening to changes in MDM parameters, we just read them when necessary, and in this case, we decide if we show sensitive information or not (by reading the MDM parameter) every time we enable logs.

michaelstingl commented 8 months ago

This is because we cannot perform an active listening to changes in MDM parameters, we just read them when necessary, and in this case, we decide if we show sensitive information or not (by reading the MDM parameter) every time we enable logs.

Okay for me, that MDM config changes require a restart of the app. iOS app for example triggers a notification to tell the user to close and re-open the app.

jesmrec commented 8 months ago

QA checks

OK from my side