owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.79k stars 3.05k forks source link

Unify http log #4258

Closed TheOneRing closed 8 months ago

TheOneRing commented 8 months ago

In https://github.com/owncloud/client/issues/11224#issuecomment-1801413850 we discussed starting the http log with

REQUEST x-id {
RESPONSE x-id {

The andorid client currently has the following format:


HTTP REQUEST: {
HTTP RESPONSE: {
Aitorbp commented 8 months ago

In this issue the following problem will also be developed: In some requests the following literal is appearing: "data": "<-- Body end for response -- Binary -- Omitted: 151 bytes -->". This is not correct, a Json should appear and not a binary.

jesmrec commented 8 months ago

new format:

D: 2023-12-22 10:29:14:435(LogInterceptor.kt:67)REQUEST 87c359e2-ed2d-4ab8-b52b-af36e33d8219 {"request":{"headers":{"X-Request-ID":"87c359e2-ed2d-4ab8-b52b-af36e33d8219","User-Agent":"Mozilla/5.0 (Android) ownCloud-android/4.2-beta.1","Accept-Language":"en","Accept-Encoding":"identity","Authorization":"Bearer [redacted]","Host":"159.69.153.173:9200","Connection":"Keep-Alive"},"info":{"id":"87c359e2-ed2d-4ab8-b52b-af36e33d8219","method":"GET","url":"https://159.69.153.173:9200/ocs/v2.php/cloud/user?format=json"}}}

D: 2023-12-22 10:29:14:445(LogInterceptor.kt:133)RESPONSE 87c359e2-ed2d-4ab8-b52b-af36e33d8219 {"response":{"body":{"data":"{\"ocs\":{\"meta\":{\"status\":\"ok\",\"statuscode\":200,\"message\":\"OK\"},\"data\":{\"id\":\"user1\",\"display-name\":\"Joe Smith\",\"email\":\"a@a.com\",\"user-type\":\"primary\"}}}","length":153},"headers":{"Content-Length":"153","Content-Type":"application/json; charset=utf-8","Date":"Fri, 22 Dec 2023 09:29:14 GMT","Ocs-Api-Version":"2","Vary":"Origin","X-Request-Id":"87c359e2-ed2d-4ab8-b52b-af36e33d8219"},"info":{"id":"87c359e2-ed2d-4ab8-b52b-af36e33d8219","method":"GET","reply":{"cached":false,"duration":166,"durationString":"duration(0h, 0min, 0s, 166ms)","status":200,"version":"http/1.1"},"url":"https://159.69.153.173:9200/ocs/v2.php/cloud/user?format=json"}}}