owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.79k stars 3.05k forks source link

[FIX] Some bugs related to Details view #4265

Closed JuancaG05 closed 7 months ago

JuancaG05 commented 8 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4188

QA

Checks done: https://github.com/owncloud/android/pull/4265#issuecomment-1880888664

jesmrec commented 7 months ago

Checks done:

Report (1) tested with:

Report (2)

jesmrec commented 7 months ago

(1) [FIXED]

This is a weird behaviour that i only reproduce in oCIS with images that are not in root folder

  1. Open the image
  2. Click on 3-dot-button and Details

Current: Displayed root folder, no matter the space in which the image is Expected: Details open

NOTE:

Pixel 2 Android 11 Samsung Tab 8, Android 13 57fdf5b1f

jesmrec commented 7 months ago

(1) is reproducible in 4.1.1 so it could be moved to another issue (not a regression). But, that problem prevents to reproduce correctly the 2nd report in the issue.

Checking with an image in root folder, the 2nd item is fixed.

So, here we have to choose between two options:

open to discussion

JuancaG05 commented 7 months ago

Since it was an ugly bug, I decided to fix it here. (1) should be solved and fixes in this PR already testable 👍

jesmrec commented 7 months ago

(1) fixed

jesmrec commented 7 months ago

Approved an my side