owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.79k stars 3.05k forks source link

[FEATURE REQUEST] Add placeholder icon for .docxf files #4267

Closed jesmrec closed 6 months ago

jesmrec commented 8 months ago

.docxf format will be supported by oCIS (open-with-web), so it will be usual to find such kind of files in the lists.

We should assign it a thumbnail-placeholder that is not the default one.

Screenshot 2023-12-18 at 12 59 12

TASKS

kulmann commented 8 months ago

oC Web introduced an icon mapping in https://github.com/owncloud/web/pull/10037 and the icon lives here https://github.com/owncloud/web/blob/master/packages/design-system/src/assets/icons/resource-type-form-fill.svg

michaelstingl commented 8 months ago

Icons from remixicon.com?

jesmrec commented 7 months ago

Add also to the "New Document" menu inside the FAB

Aitorbp commented 7 months ago

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Image

michaelstingl commented 7 months ago

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Could you post a link to the Google dev docs with the overview page of all available file type icons?

kulmann commented 7 months ago

Icons from remixicon.com?

No. Usually our file type icons are taken from font awesome v5. But in this case I think @tbsbdr made custom ones.

Aitorbp commented 7 months ago

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Could you post a link to the Google dev docs with the overview page of all available file type icons?

Here you have: https://fonts.google.com/icons

Captura de pantalla 2024-01-24 a las 8 37 53

By the way, from this page we can only get the black and white colors. But from Android Studio we can change the color and customize them a little. They are also the same icons. You can see below:

Image

tbsbdr commented 7 months ago

@michaelstingl I can fiddle together this file (https://github.com/owncloud/web/blob/master/packages/web-pkg/src/helpers/resource/icon.ts) for you so that you get: fileextensions, color and icon. would that be helpful for you?

imo its its not so important for the user to see the exact same icon, it's okayish to see a similar icon. Color is more important for quick orientation in the fileslist i'd say.

Aitorbp commented 6 months ago

I have changed the color of the icon to the same one that is on the website. new_image_docxf