owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.79k stars 3.05k forks source link

[FEATURE REQUEST] Upload & Download Notification #4271

Open parneet-guraya opened 8 months ago

parneet-guraya commented 8 months ago

Currently while Uploading or Downloading there's no notification about the progress. It would be nice if we notify about the ongoing task to the user through notification.

https://github.com/owncloud/android/assets/111801812/c1279f33-f514-4b6c-8883-76b05b12005f

We can have something like GDrive has -->

Do let me know and I would like to work on this.

jesmrec commented 8 months ago

In the past, we had notifications over the uploads but finally were removed because the info was also available in the uploads view. Now, we keep notifications for uploads in case of failure. Downloads do not have a "downloads view" like the uploads, for that reason notifications are still there.

parneet-guraya commented 8 months ago

Hi @jesmrec 👋

Okay, I get that it was present in the past and made sense to remove the feature as we already had the same in uploads view.

But, I would like to revisit the idea again and give you more insights and I believe these are the uses cases where I think it would be better in terms of user experience -->

https://github.com/owncloud/android/assets/111801812/14b5c837-3de4-4b23-842c-d1c48c5b2df7

Do let me know if you agree :-)

jesmrec commented 8 months ago

Your proposal seems ok, but take in account another scenario: when someone selects a huge amount of uploads at the time, f.ex. 1000 files that also are not so big (upload very fast). In that case, notifications cause a tingling effect because appear and disappear very fast in the screen. Grouping them caused also problems... what do you think?

rohnsha0 commented 6 months ago

@jesmrec can't we send a single notification when the upload (whole) is completed?!

parneet-guraya commented 6 months ago

@rohnsha0 Even if you push the notification on completion, the concern about multiple notifications being pushed still exists. For example you upload 10 items. If every item has a different size it would take a different time to complete then wouldn't it push the notifications for all at different time? And if you say we group then what if the user dismisses the notification and the task is still going on, which means on completion it would again push it. It needs a bit more thinking to make it. Like keeping track of the enqueued task (uploads/downloads) batch and then just handle single notification for it. Means it should be graceful for the user and I'm looking into it 🚀. Anyways thanks for your suggestion. 👍