Closed Aitorbp closed 7 months ago
I will show you the new behaviour in this video:
https://github.com/owncloud/android/assets/34248951/b4c67e3c-4a5d-4d03-a071-33a1a451660a
No tests were added to the PR, is that right? (not UI tests, that are put for the moment off)
No tests were added to the PR, is that right? (not UI tests, that are put for the moment off)
Right, there was no need to add or modify tests in repositories or data sources, which are the ones we actually maintain (other layers will come afterwards adding the necessary tests)
In the first iteration, banned passwords were not supported.
In oCIS server with password policy support, 400
is returned when password matches with a banned password. After researching a little bit over the supported error codes, we can conclude that 400
is unique for such scenario all over the scenarios supported by the app. Other supported errors return 404
, and in case of 400
(like error of incorrect sharedType), are prevented errors from scratch.
So, banned password error will be handled as 400 error for sharing.
Also assuming that OCS API is in "maintenance" to be replaced soon, so likely changes in the API will not happen ftm.
Let's go for this approach.
Moving this forward.
Related Issues
App: https://github.com/owncloud/android/issues/4269
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/Password%20Policy.md