[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud)

michaelstingl commented 7 months ago

Actual behaviour

4.1.1 Android app queries /owncloud/owncloud/index.php/app/list when instance is installed in subfolder /owncloud

Expected behaviour

Leading / should add "apps_url": "/owncloud/index.php/app/list", to host, not to server URL

Steps to reproduce

Connect Android app to ownCloud instance installed in subfolder /owncloud

Can this problem be reproduced with the official owncloud server? (url: https://demo.owncloud.org, user: test, password: test)

no

Environment data

ownCloud app version: 4.1.1 cde9bb841

ownCloud server version:

            "version":
            {
                "major": 10,
                "minor": 13,
                "micro": 4,
                "string": "10.13.4",
                "edition": "Community",
                "product": "ownCloud"
            },

Logs

Capabilities:

                    "app_providers":
                    [
                        {
                            "enabled": true,
                            "version": "1.1.0",
                            "apps_url": "/owncloud/index.php/app/list",
                            "open_web_url": "/owncloud/index.php/app/open-with-web",
                            "new_url": "/owncloud/index.php/app/new"
                        }
                    ],

Request to composed URL:

D: 2024-01-03 08:07:44:103(LogBuilder.kt:38) .logHttp()[Network, request] [info] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Method: GET URL: https://example.com/owncloud/owncloud/index.php/app/list
D: 2024-01-03 08:07:44:104(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Request-ID: 05f707f0-4c10-4d1e-8d46-27f04e6d2671
D: 2024-01-03 08:07:44:105(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] User-Agent: Mozilla/5.0 (Android) ownCloud-android/4.1.1
D: 2024-01-03 08:07:44:106(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Accept-Language: en
D: 2024-01-03 08:07:44:107(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Accept-Encoding: identity
D: 2024-01-03 08:07:44:108(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Authorization: [redacted]
D: 2024-01-03 08:07:44:110(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Host: example.com
D: 2024-01-03 08:07:44:111(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Connection: Keep-Alive
D: 2024-01-03 08:07:44:112(LogBuilder.kt:38) .logHttp()[Network, request] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Cookie: REDACTED

D: 2024-01-03 08:07:44:113(LogBuilder.kt:38) .logHttp()[Network, request] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Empty body
D: 2024-01-03 08:07:44:300(LogBuilder.kt:38) .logHttp()[Network, response] [info] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Method: GET URL: https://example.com/owncloud/owncloud/index.php/app/list Code: 404 Message: Not Found
D: 2024-01-03 08:07:44:301(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Date: Wed, 03 Jan 2024 05:07:44 GMT
D: 2024-01-03 08:07:44:303(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Server: Apache/2.4.52 (Ubuntu)
D: 2024-01-03 08:07:44:304(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Strict-Transport-Security: max-age=15552000; includeSubDomains
D: 2024-01-03 08:07:44:306(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Content-Type-Options: nosniff
D: 2024-01-03 08:07:44:308(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-XSS-Protection: 0
D: 2024-01-03 08:07:44:309(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Robots-Tag: none
D: 2024-01-03 08:07:44:310(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Frame-Options: SAMEORIGIN
D: 2024-01-03 08:07:44:312(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Download-Options: noopen
D: 2024-01-03 08:07:44:313(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] X-Permitted-Cross-Domain-Policies: none
D: 2024-01-03 08:07:44:314(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Content-Length: 196
D: 2024-01-03 08:07:44:316(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Keep-Alive: timeout=5, max=43
D: 2024-01-03 08:07:44:317(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Connection: Keep-Alive
D: 2024-01-03 08:07:44:318(LogBuilder.kt:38) .logHttp()[Network, response] [header] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Content-Type: text/html; charset=iso-8859-1
D: 2024-01-03 08:07:44:319(LogBuilder.kt:38) .logHttp()[Network, response] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Length: 196 byte body
D: 2024-01-03 08:07:44:320(LogBuilder.kt:38) .logHttp()[Network, response] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] Type: text/html; charset=iso-8859-1
D: 2024-01-03 08:07:44:321(LogBuilder.kt:38) .logHttp()[Network, response] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] --> Body start for response
D: 2024-01-03 08:07:44:323(LogBuilder.kt:38) .logHttp()[Network, response] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL was not found on this server.</p>
</body></html>

D: 2024-01-03 08:07:44:324(LogBuilder.kt:38) .logHttp()[Network, response] [body] [05f707f0-4c10-4d1e-8d46-27f04e6d2671] <-- Body end for response -- Omitted: 0 bytes

Logs and screenshots: