owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.05k forks source link

[FEATURE REQUEST] [OIDC] Branding option to remove `login_hint` and `user` parameter from re-login URL #4288

Closed michaelstingl closed 5 months ago

michaelstingl commented 5 months ago

Is your feature request related to a problem? Please describe.

The ownCloud-internal username not always works fine on the OpenID Connect IdP. When ownCloud clients append &login_hint=test&user=test to the re-login URL, in some cases the IdP has no way to let the user log in again.

Describe the solution you'd like

I'd need a branding option to remove "login_hint" and "user" parameter from re-login URL.

Describe alternatives you've considered

We discussed requesting other user attributes from the /ocs/v1.php/cloud/user endpoint, and using those for the "login_hint" and "user", but it sounds like a nightmare to maintain and test.

Additional context

Re-login URL:

https://demo.owncloud.com/index.php/apps/oauth2/authorize?response_type=code
&client_id=xdXOt13JKxym1B1QcEncf2XDkLAexMBFwiT9j6EfhhHFJhs2KM9jbjTmf8JBXE69
&redirect_uri=http://localhost:61901
&code_challenge=DSdzUn4on0L_NTAXYQ-_Iwk8y2KGsn9bzatz0roYy5I
&code_challenge_method=S256
&scope=openid offline_access email profile
&prompt=select_account consent
&state=ifvvlCpuaSiQxC7UhvjyHoXWFFDgvaltQmkr7wLiQPM%3D
&login_hint=test
&user=test

TASKS

@JuancaG05 @Aitorbp @jesmrec any chance we can get this in the upcoming 4.2 release?

/cc @steelcuts

michaelstingl commented 5 months ago

Related:

Aitorbp commented 5 months ago

We will take a look, I think it could be in the upcoming 4.2 release. 👍 @michaelstingl

jesmrec commented 5 months ago
  1. Add login_hint
  2. Add branding / MDM parameter

Default: true ¿?