search

owncloud / android

:phone: The ownCloud Android App
GNU General Public License v2.0
3.77k stars 3.05k forks source link

[RELEASE] 4.2.0 #4306

Closed Aitorbp closed 5 months ago

Aitorbp commented 5 months ago

Related Issues

App: https://github.com/owncloud/android/issues/4254

QA

jesmrec commented 5 months ago

(1) [FIXED]

  1. Install latest stable version 4.1.1
  2. Enter in Settings > Logging > enable logs
  3. Update to current version

Current: app crashes just after opening Expected: no crash, migration completed

Seems to be a problem with the date format. This is the stacktrace:

FATAL EXCEPTION: main
                 Process: com.owncloud.android.debug, PID: 22679
                 java.lang.RuntimeException: Unable to create application com.owncloud.android.MainApp: java.text.ParseException: Unparseable date: "2024-02-06"
                    at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6717)
                    at android.app.ActivityThread.access$1300(ActivityThread.java:237)
                    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
                    at android.os.Handler.dispatchMessage(Handler.java:106)
                    at android.os.Looper.loop(Looper.java:223)
                    at android.app.ActivityThread.main(ActivityThread.java:7656)
                    at java.lang.reflect.Method.invoke(Native Method)
                    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
                 Caused by: java.text.ParseException: Unparseable date: "2024-02-06"
                    at java.text.DateFormat.parse(DateFormat.java:362)
                    at com.owncloud.android.lib.common.utils.OCFileLoggingTree.<init>(OCFileLoggingTree.kt:68)
                    at com.owncloud.android.lib.common.utils.OCFileLoggingTree.<init>(OCFileLoggingTree.kt:37)
                    at com.owncloud.android.lib.common.utils.LoggingHelper.startLogging(LoggingHelper.kt:38)
                    at com.owncloud.android.providers.LogsProvider.startLogging(LogsProvider.kt:45)
                    at com.owncloud.android.MainApp.startLogsIfEnabled(MainApp.kt:239)
                    at com.owncloud.android.MainApp.onCreate(MainApp.kt:99)
                    at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
                    at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
                    at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
                    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
                    at android.os.Handler.dispatchMessage(Handler.java:106) 
                    at android.os.Looper.loop(Looper.java:223) 
                    at android.app.ActivityThread.main(ActivityThread.java:7656) 
                    at java.lang.reflect.Method.invoke(Native Method) 
                    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
                    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 

Pixel2 Android11 Samsung Tab A8 Android 13 65b3bccda

jesmrec commented 5 months ago

(2) [FIXED]

Not a technical one: i realised that our changelog/release notes are not complete. Some contributions from community are missing there:

https://github.com/owncloud/android/pull/4263 https://github.com/owncloud/android/pull/4183 https://github.com/owncloud/android/pull/4177

jesmrec commented 5 months ago

about (2), added some comments to the newly added entries.

jesmrec commented 5 months ago

(3) [WONT FIX]

a very weird behaviour:

  1. Create a deeplink over any item in oCiS account (not tested with oC10)
  2. Click the link to check that it opens the app and the correct file or folder
  3. Go to device Settings > Apps > ownCloud
  4. Clear cache and storage
  5. Click again on the link of step 2

Current behaviour:

Unknown error. Also, i noticed that the spaces warning ocis_accounts_warning_message is displayed

Pixel2 Android11 Samsung Tab A8 Android 13 f54a7cee2

JuancaG05 commented 5 months ago

(3) was due to the malfunction of the "Clear data" option, which put the database in a weird inconsistent state. But this is not a regression, so it was solved temporally by disabling the Clear data button and we'll work on it in a separate issue

jesmrec commented 5 months ago

Release 4.2.0 is approved on my side.

Approved commit: 25de31ec8

Android Studio version: Android Studio Hedgehog | 2023.1.1 Patch 2

Devices:

Pixel2, Android11 Samsung Galaxy Tab A8, Android13

Regression Test: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/RegressionTest.md Autom test execution vs oC 10.13.4: https://reports.cucumber.io/reports/68cb56b4-7f3b-444b-96dd-405c5bb95093 Autom test execution vs oCIS5: https://reports.cucumber.io/reports/5b315360-af4e-460d-ab43-82f0d8905603

Great job, team!!